-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Tor avatar menu after c78 bump. #3686
Conversation
1512dc5
to
3106d7a
Compare
@bsclifton, yep, I might have skipped a return 🤣 |
Also, removed no longer used override in chromium_src's profiles_state.cc. Fixes brave/brave-browser#6451
3106d7a
to
7a25f04
Compare
Only lint and unrelated browser test failed in CI. |
Changes work great 😄 While testing this, I noticed a weird regression - cc: @yrliou who has done Tor work in Nightly (it may be due to that work? or Chromium 78? not sure) Basically, in Dev channel for example (C77), when in a private window with Tor, you're not given the option to create a regular private window On master/Nightly, when in a private window with Tor, you're shown the option to open a new private window. If you do choose this, it opens a private window with Tor, NOT a regular private window. @yrliou is this related to the work you did? Either way, I think I'll create an issue 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed LGTM! Created brave/brave-browser#6467 to track the unrelated issue I found
Fixes Tor avatar menu after c78 bump.
Fixes Tor avatar menu after c78 bump.
Also, removed no longer used override in chromium_src's profiles_state.cc.
Fixes brave/brave-browser#6451
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Tor
andExit Tor
options.Reviewer Checklist:
After-merge Checklist:
changes has landed on.