Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Compat suffix from Preferences in xml files #3663

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Oct 10, 2019

Fix brave/brave-browser#6420

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@yrliou yrliou added this to the 0.72.x - Nightly milestone Oct 10, 2019
@yrliou yrliou self-assigned this Oct 10, 2019
@yrliou yrliou added CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Oct 10, 2019
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@yrliou
Copy link
Member Author

yrliou commented Oct 10, 2019

I'm going to skip CI on this one since these won't be catched by CI but only happens in runtime.
I have manually built and checked that Settings subpage could be shown normally again in Android with this PR.

@yrliou yrliou merged commit 1523c00 into master Oct 10, 2019
@yrliou yrliou deleted the remove_compat_suffix_in_xml branch October 10, 2019 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Compat suffix from Preferences in xml files
3 participants