Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fail-safe WaitableEvent::TimedWait() because (uplift to 0.69.x) #3644

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Remove fail-safe WaitableEvent::TimedWait() because (uplift to 0.69.x) #3644

merged 1 commit into from
Oct 10, 2019

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Oct 9, 2019 •
edited by bsclifton
Loading

Uplift of #3636
Fixes brave/brave-browser#6367

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from bridiver as a code owner October 9, 2019 15:39
@brave-builds brave-builds self-assigned this Oct 9, 2019
@brave-builds brave-builds added this to the 0.69.x - next release milestone Oct 9, 2019
@bsclifton bsclifton requested review from a team and removed request for bbondy, kjozwiak, bsclifton, rebron, srirambv and bridiver October 9, 2019 15:40
@bsclifton bsclifton added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Oct 9, 2019
@bsclifton
Copy link
Member

Passed on everything except Windows; gonna try a re-run here

kjozwiak
kjozwiak approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.69.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins & CI/Travis passed without any issues after Windows was restarted. Please make sure that all the correct labels are added and the associated issue is moved into the correct milestone.

@bsclifton bsclifton merged commit 0a8eda9 into 0.69.x Oct 10, 2019
@bsclifton bsclifton deleted the pr3636_waitable-event-timewait_0.69.x branch October 10, 2019 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
0.69.x - Release Hotfix 1
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @bsclifton @kjozwiak @brave-browser-releases