Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable motion sensors and background sync by default #3553

Merged
merged 3 commits into from
Oct 1, 2019

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Sep 26, 2019

Fixes brave/brave-browser#4709 and brave/brave-browser#4789 without reintroducing the problems that got #2802 reverted in #3517.

Submitter Checklist:

Test Plan:

For background sync:

  1. Load https://deanhume.github.io/Service-Workers-BackgroundSync/
  2. Open the devtools console.
  3. Press the "Make an HTTP request - do it!" button.
  4. Look for "Unable to fetch image." in the console (and not "sync registered").

For either feature:

  1. Load https://brave.com
  2. Click the padlock icon in the URL bar.
  3. Click "Site settings".
  4. Look for "Motion sensors" and "Background sync". They should both be labeled "Block (default)".

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@fmarier fmarier added this to the 0.72.x - Nightly milestone Sep 26, 2019
@fmarier fmarier self-assigned this Sep 26, 2019
@fmarier fmarier force-pushed the francois-disable-sensors-background-sync branch from b33821d to 104ea33 Compare September 26, 2019 23:51
@fmarier fmarier changed the title Francois disable sensors background sync Disable motion sensors and background sync by default Sep 26, 2019
@fmarier fmarier force-pushed the francois-disable-sensors-background-sync branch from 104ea33 to 2026542 Compare September 30, 2019 22:40
@fmarier fmarier merged commit e325ae9 into master Oct 1, 2019
@fmarier fmarier deleted the francois-disable-sensors-background-sync branch October 1, 2019 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Background Sync should be disabled by default
2 participants