Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes blank panel #3426

Merged
merged 1 commit into from
Sep 17, 2019
Merged

Fixes blank panel #3426

merged 1 commit into from
Sep 17, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Sep 13, 2019

Resolves brave/brave-browser#6012

Submitter Checklist:

Test Plan:

defined in the issue

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@bsclifton
Copy link
Member

As discussed, this does fix the symptom - but the root cause as we found was that data is in a bad state when loading

@bsclifton
Copy link
Member

bsclifton commented Sep 16, 2019

@NejcZdovc I think we need this along with 7d80348, right?
(in 0.69.x / 0.70.x / 0.71.x / master)

We merged both in 0.68.x for Chromium 77:

@bsclifton bsclifton self-requested a review September 16, 2019 23:37
@bsclifton bsclifton added this to the 0.72.x - Nightly milestone Sep 16, 2019
@NejcZdovc
Copy link
Contributor Author

@bsclifton that is correct, let me put it in the PR

@NejcZdovc NejcZdovc marked this pull request as ready for review September 17, 2019 05:11
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 3734038 into master Sep 17, 2019
@bsclifton bsclifton deleted the white-box branch September 17, 2019 16:38
brave-builds pushed a commit that referenced this pull request Sep 17, 2019
brave-builds pushed a commit that referenced this pull request Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewards panel shows white popup
2 participants