Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Tabs Page: Enable NTP to be theme aware #3115

Merged
merged 1 commit into from
Aug 14, 2019
Merged

Conversation

imptrx
Copy link
Contributor

@imptrx imptrx commented Aug 7, 2019

Closes brave/brave-browser#5014
Themes/Styling were pre-built in an earlier PR for storybook (brave/brave-ui#485)
Quick view:
ntp-theme

Submitter Checklist:

Test Plan:

1 Set theme settings to 'Light'/'Dark'/'Same as OSX' from brave://settings
2 Open NTP's customization menu
3 Menu should be themed accordingly
4. Menu should dynamically update theme when if "Same as OS theme"* is set

*Assuming native OS supports dark mode - otherwise this option wouldn't be available from settings

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@imptrx imptrx added this to the 0.70.x - Nightly milestone Aug 7, 2019
@imptrx imptrx self-assigned this Aug 7, 2019
@imptrx imptrx force-pushed the pxu-ntp-darkmode branch 2 times, most recently from 3ba14b4 to c2523fa Compare August 12, 2019 18:24
@imptrx imptrx marked this pull request as ready for review August 12, 2019 21:38
petemill
petemill previously approved these changes Aug 12, 2019
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ 🎨 🕶 🌡

@petemill
Copy link
Member

CI didn't run because it was marked draft, and some reason hasn't re-run automatically, so I'll press the button now.

@bsclifton
Copy link
Member

😎👌

@imptrx
Copy link
Contributor Author

imptrx commented Aug 13, 2019

Rebasing as latest Jenkins build failed due to a version mismatch

Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cezaraugusto
Copy link
Contributor

triggered a new rebuild

@imptrx imptrx merged commit bbcf469 into master Aug 14, 2019
@imptrx imptrx deleted the pxu-ntp-darkmode branch August 14, 2019 16:56
@cezaraugusto
Copy link
Contributor

changing milestones as this work landed only in 0.70.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark mode for new tabs page settings
4 participants