Support alternate private search engine provider #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonhong
force-pushed
the
support_alternate_private_search_engine
branch
2 times, most recently
from
eb95ec2 to
ccd4b93
Compare
simonhong
changed the title
simonhong
force-pushed
the
support_alternate_private_search_engine
branch
2 times, most recently
from
87ea963 to
446cf52
Compare
simonhong
force-pushed
the
support_alternate_private_search_engine
branch
from
446cf52 to
d8f8922
Compare
bbondy
reviewed
Aug 10, 2018
| private_search_engine_data.SetShortName(base::ASCIIToUTF16("DuckDuckGo")); | ||
| private_search_engine_data.SetKeyword(base::ASCIIToUTF16("duckduckgo.com")); | ||
| private_search_engine_data.SetURL( | ||
| "https://duckduckgo.com/?q={searchTerms}&atb=v128-6_e"); |
There was a problem hiding this comment.
I won't block on this but please fix in a follow up.
what is this for? &atb=v128-6_e
Please remove that and instead add the brave referral code of t=brave
bbondy
previously approved these changes
Aug 10, 2018
|
Please rebase and also fix the query parameter and then I'll re-approve and merge. |
Use different TemplateURLService for normal and incognito mode to set default search engine provider independently. Use duckduckgo as a default search engine provider in incognito mode. kUseAlternatePrivateSearchEngine pref is introduced to toggle alternate search engine. If it is set to false, incognito mode uses default search engine of normal mode.
Connect that button with kUseAlternatePrivateSearchEngine pref.
simonhong
force-pushed
the
support_alternate_private_search_engine
branch
from
d8f8922 to
0bb0660
Compare
bbondy
approved these changes
Aug 10, 2018
fmarier
pushed a commit
that referenced
this pull request
Oct 29, 2019
add uglifyjs-webpack-plugin as dep
This was referenced Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use different TemplateURLService for normal and incognito mode to set default search engine provider independently.
Use duckduckgo as a default search engine provider in incognito mode.
kUseAlternatePrivateSearchEngine pref is introduced to toggle alternate search engine.
If it is set to false, incognito mode uses default search engine of normal mode.
Otherwise, duckduckgo is used as private mode default search engine.
Close brave/brave-browser#61
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
yarn test brave_browser_tests --filter=AlternatePrivateSearchEngineTest.PrefTestReviewer Checklist: