Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linux build error #304

Merged
merged 2 commits into from
Aug 1, 2018
Merged

Fix linux build error #304

merged 2 commits into from
Aug 1, 2018

Commits on Aug 1, 2018

  1. Fix BraveAutocompleteController undefined reference error on debug build 

    This error occurs when builds vr_common target.
In C69, vr_common target is changed from static lib to shared lib.
and vr_common depends on components/omnibox/browser target.
To fix undefined reference to BraveAutocompleteController when builds
vr_common shared lib, components/omnibox/browser should include
brave/components/omnibox/browser.
    @simonhong
    simonhong committed Aug 1, 2018
    Configuration menu
    Copy the full SHA
    da8b0a0 View commit details
    Browse the repository at this point in the history

  2. Fix undefined brave::GetChannelImpl when builds vr_common shared lib 

    In C69, vr_common target changed to shared lib.
It has dependency chrome/common:channel_info and
chrome/common:channel_info calls brave's code.
To fix, our additional channel info implementation is added to
chrome/common:channel_info target.
    @simonhong
    simonhong committed Aug 1, 2018
    Configuration menu
    Copy the full SHA
    723ce1c View commit details
    Browse the repository at this point in the history