Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes Crypto Wallets menu item in official builds (0.69) #3015

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Removes Crypto Wallets menu item in official builds (0.69) #3015

merged 1 commit into from
Jul 25, 2019

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Jul 25, 2019

Uplift For: #3006
Fixes: brave/brave-browser#5383

@ryanml
Merge pull request #3006 from brave/fix-menu-item
2895a63 
Removes Crypto Wallets menu item in official builds
@ryanml ryanml requested a review from a team July 25, 2019 17:50
@ryanml ryanml self-assigned this Jul 25, 2019
bbondy
bbondy approved these changes Jul 25, 2019
View reviewed changes
Copy link
Member

@bbondy bbondy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please verify it's working on Nightly before merging.

@ryanml
Copy link
Contributor Author

ryanml commented Jul 25, 2019

Verified link is no longer present on official nightly build (0.70.8)

Screen Shot 2019-07-25 at 2 58 02 PM

@ryanml ryanml merged commit 8181f27 into 0.69.x Jul 25, 2019
@ryanml ryanml deleted the menu-item-fix-69 branch July 25, 2019 21:58
@kjozwiak kjozwiak added this to the 0.69.x - Dev milestone Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy bbondy approved these changes

Assignees

@ryanml ryanml

Labels
feature/eth-wallet
Projects
None yet
Milestone
0.69.x-backup
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanml @bbondy @kjozwiak