Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linux debug build #292

Merged
merged 1 commit into from
Jul 28, 2018
Merged

Fix linux debug build #292

merged 1 commit into from
Jul 28, 2018

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Jul 27, 2018

Need to consider development channel name in channels.gni just to avoid gn error because
we started to set it as a channel name in debug build from brave/brave-browser#653.
This change doesn't affect anything because we don't make debug build package.

Close brave/brave-browser#654

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.

Test Plan:

Try debug build in linux

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions

In debug build, `development` is set to channel. Need to handle it
in channels.gni.
@simonhong simonhong self-assigned this Jul 27, 2018
@simonhong simonhong requested a review from bridiver July 27, 2018 09:53
@bridiver
Copy link
Collaborator

I think this one needs @mbacchi as well

@bridiver bridiver requested a review from mbacchi July 27, 2018 17:31
@mbacchi
Copy link
Contributor

mbacchi commented Jul 27, 2018

looks good to me!

@simonhong
Copy link
Member Author

Thanks for checking. Ready to approve this? :)

@simonhong simonhong merged commit c0f1c3a into master Jul 28, 2018
@simonhong simonhong deleted the fix_linux_debug_build branch July 28, 2018 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants