-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fingerprinting exception for Uphold #2773
Conversation
bb07363
to
526436d
Compare
526436d
to
2006c9a
Compare
2006c9a
to
9a0c3e1
Compare
rebased so this can re-run CI |
Followed the steps outlined here - ran into an issue...
At this point, I can't start the process over again |
@bsclifton @diracdeltas Does this PR also address the following? I've also had experiences where i've been able to get past this but my document actually didn't upload 😭 |
@corymcdonald yes that's the same issue |
if anyone else gets stuck in verification while trying to test this and can't retry, ask in the uphold slack channel for someone to reset your verification state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(code changes look great too - sorry for the mean mugging; I was actually happy to test this change) |
Fix brave/brave-browser#4139
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.