Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fingerprinting exception for Uphold #2773

Merged
merged 1 commit into from
Jun 27, 2019
Merged

Add fingerprinting exception for Uphold #2773

merged 1 commit into from
Jun 27, 2019

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Jun 22, 2019

Fix brave/brave-browser#4139

Submitter Checklist:

Test Plan:

  1. Go to uphold.com. Make an account and login.
  2. Click on the link to verify your identity (as shown in Shield prevents identity verification with webcam when trying to KYC with Uphold brave-browser#4139 (comment))
  3. When it asks you to submit ID, allow camera access
  4. You should be able to take a picture of your ID

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@diracdeltas diracdeltas self-assigned this Jun 22, 2019
@diracdeltas diracdeltas changed the title Add fingerprinting exception for Uphold WIP Add fingerprinting exception for Uphold Jun 24, 2019
@diracdeltas diracdeltas changed the title WIP Add fingerprinting exception for Uphold Add fingerprinting exception for Uphold Jun 24, 2019
@bsclifton
Copy link
Member

rebased so this can re-run CI

@bsclifton
Copy link
Member

bsclifton commented Jun 26, 2019

Followed the steps outlined here - ran into an issue...

  • created account 👍
  • verified email, etc
  • logged in, clicked begin verify
  • picked drivers license
  • browser asked for camera access 👍 I clicked allow
  • my camera light did come on! 🎉
  • because I launched via npm run start -- Release the OS then asked me "iTerm is trying to access the camera"
  • I clicked "okay" (or whatever it presented). I think it was just an acknowledgement. Does macOS require you to grant access via Accessibility on Mojave? Fresh install on a new machine would likely show the same dialog, but for Brave. I think it's tied to this:

Screen Shot 2019-06-26 at 12 25 01 AM

  • Uphold camera process timed out at this point- camera light turned itself off
  • verification kicked out saying it would be manually reviewed 🙀

Screen Shot 2019-06-26 at 12 15 38 AM

At this point, I can't start the process over again ☹️

@corymcdonald
Copy link

@bsclifton @diracdeltas Does this PR also address the following?

brave/brave-browser#2993

I've also had experiences where i've been able to get past this but my document actually didn't upload 😭

@diracdeltas
Copy link
Member Author

@corymcdonald yes that's the same issue

@diracdeltas
Copy link
Member Author

if anyone else gets stuck in verification while trying to test this and can't retry, ask in the uphold slack channel for someone to reset your verification state.

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After Uphold reset the KYC process and I added iTerm (since that's what kicked off the npm run start -- Release) to accessibility (under security and options)... it worked great!
Screen Shot 2019-06-26 at 1 03 41 PM

Screen Shot 2019-06-26 at 1 03 20 PM

@bsclifton
Copy link
Member

bsclifton commented Jun 26, 2019

(code changes look great too - sorry for the mean mugging; I was actually happy to test this change)

@diracdeltas diracdeltas merged commit e00f063 into master Jun 27, 2019
@diracdeltas diracdeltas deleted the fix/uphold-kyc branch June 27, 2019 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shield prevents identity verification with webcam when trying to KYC with Uphold
3 participants