Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wallet is in a persisted bad state until wallet recovery is complete - 0.67.x #2738

Merged
merged 1 commit into from
Jun 25, 2019

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jun 19, 2019

Fixes brave/brave-browser#4794
Uplift request from #2655

@tmancey tmancey added this to the 0.67.x - Dev milestone Jun 19, 2019
@tmancey tmancey requested a review from a team June 19, 2019 07:57
@tmancey tmancey self-assigned this Jun 19, 2019
@tmancey tmancey changed the title Fix wallet is in a persisted bad state until wallet recovery is complete Fix wallet is in a persisted bad state until wallet recovery is complete - 0.67.x Dev Jun 19, 2019
@tmancey tmancey changed the title Fix wallet is in a persisted bad state until wallet recovery is complete - 0.67.x Dev Fix wallet is in a persisted bad state until wallet recovery is complete - 0.67.x Jun 21, 2019
@tmancey tmancey force-pushed the issues/4794-0.67.x branch 2 times, most recently from 1bf4cb5 to c9dc1c4 Compare June 25, 2019 03:01
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some lints failures (would be nice to fix) but tests all passed. Failure due to xUnit test parsing and S3 upload (not critical). Approved! 😄

@bsclifton bsclifton merged commit 74aa020 into 0.67.x Jun 25, 2019
@bsclifton bsclifton deleted the issues/4794-0.67.x branch June 25, 2019 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants