-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new Rust based ad-block library #2569
Conversation
592c470
to
8c1d830
Compare
cce1b54
to
555e37c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, had a couple of minor typo nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No successful CI build yet (and I can't build locally on mac at the moment) so I am not sure where libadblock ends up and if the signing script needs to be patched to have it signed.
e56dbe6
to
f7bb6b9
Compare
Do you mean you can't build this PR in particular? Or you can't build at all?
There's a commit to do the signing of it already. I haven't verified on CI if that works yet though. |
Just meant I was on Windows and couldn't switch to Mac at that moment. |
292f9b5
to
5199963
Compare
d8514d2
to
2d6aecf
Compare
@bbondy I think you missed one thing in that commit. |
And fix test lib path
…divdi3) This is from Terry on the android browser-android-tabs branch
Fix brave/brave-browser#4793
Please let me merge if approved, I still need to verify CI.
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security
) onnpm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.