Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.64.x] Fix dropdown colors for Shields on Windows #2383

Merged
merged 1 commit into from
May 8, 2019
Merged

Conversation

cezaraugusto
Copy link
Contributor

changes diff brave/brave-ui@294d67e...456ea87

uplift request for #2378
uplift fix for brave/brave-browser#4213

@cezaraugusto cezaraugusto requested a review from a team May 7, 2019 23:05
@cezaraugusto cezaraugusto self-assigned this May 7, 2019
@kjozwiak
Copy link
Member

kjozwiak commented May 8, 2019

@cezaraugusto can you double check to make sure that the Jenkins failure isn't associated with this specific PR? Once that's confirmed, we can get this into 0.64.x before we spin up an RC.

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only Windows had failed- I suspect the Jenkins agent disconnected while running this. I re-ran Windows only (since macOS and Linux worked fine) with https://staging.ci.brave.com/job/brave-browser-build-pr/job/ca-4213-64/2 and it all passed perfectly (artifacts uploaded to S3, etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants