Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable lookalike url feature #2382

Merged
merged 1 commit into from
May 8, 2019
Merged

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented May 7, 2019

Fix brave/brave-browser#4304

Submitter Checklist:

Test Plan:

yarn test brave_browser_tests --filter=BraveMainDelegateBrowserTest.DisabledFeatures

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@simonhong simonhong added this to the 0.67.x - Nightly milestone May 7, 2019
@simonhong simonhong requested a review from bbondy May 7, 2019 22:18
@simonhong simonhong self-assigned this May 7, 2019
@simonhong simonhong requested a review from bsclifton May 8, 2019 04:55
@simonhong
Copy link
Member Author

Yay! Builder is happy with this PR :)

@bbondy
Copy link
Member

bbondy commented May 8, 2019

Please do uplifts of this to 0.65.x after this lands on Nightly too.

@simonhong simonhong merged commit 0d4e31f into master May 8, 2019
@simonhong simonhong deleted the disable_lookalike_url_feature branch May 8, 2019 21:46
brave-builds pushed a commit that referenced this pull request May 8, 2019
brave-builds pushed a commit that referenced this pull request May 8, 2019
brave-builds pushed a commit that referenced this pull request May 8, 2019
brave-builds pushed a commit that referenced this pull request May 8, 2019
simonhong pushed a commit that referenced this pull request May 9, 2019
fmarier pushed a commit that referenced this pull request Oct 29, 2019
check src/brave/brave_sync/extension for npm vulnerabilities
petemill pushed a commit that referenced this pull request Jul 27, 2020
check src/brave/brave_sync/extension for npm vulnerabilities
petemill pushed a commit that referenced this pull request Jul 28, 2020
check src/brave/brave_sync/extension for npm vulnerabilities
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visiting bbcnews.com triggers “The link that you originally opened is unusual” warning
3 participants