Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 4335: Disable SafeBrowsing in Tor #2375

Merged
merged 1 commit into from
May 8, 2019
Merged

Issue 4335: Disable SafeBrowsing in Tor #2375

merged 1 commit into from
May 8, 2019

Conversation

jumde
Copy link
Contributor

@jumde jumde commented May 6, 2019

fix brave/brave-browser#4335

Description

SafeBrowsing checks in chromium send much more info than just IP and hashes. See here: https://cs.chromium.org/chromium/src/components/safe_browsing/proto/csd.proto

Disabling SafeBrowsing in tor for now.

Please use a Release version of Brave to verify this fix, issue to fix the DCHECK failures is being tracked here: brave/brave-browser#4321

Submitter Checklist:

Test Plan:

  1. Set up a clean profile
  2. Wait ~2 mins to make sure the hash files for SafeBrowsing are downloaded in <DATA_DIR>/Safe\ Browsing
  3. In a regular tab, navigate to https://testsafebrowsing.appspot.com - verify that safe-browsing works correctly
  4. Open a tor tab, navigate to https://testsafebrowsing.appspot.com - verify that safe-browsing does not work and no connections are made to google domains.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@jumde jumde self-assigned this May 6, 2019
@diracdeltas
Copy link
Member

@diracdeltas diracdeltas closed this May 6, 2019
@jumde jumde reopened this May 7, 2019
@jumde jumde changed the title Fix 4289: Disable SafeBrowsing in Tor Fix 4335: Disable SafeBrowsing in Tor May 7, 2019
@jumde jumde requested a review from diracdeltas May 7, 2019 17:04
@jumde jumde changed the title Fix 4335: Disable SafeBrowsing in Tor Issue 4335: Disable SafeBrowsing in Tor May 7, 2019
@diracdeltas
Copy link
Member

defer to @riastradh-brave

iefremov
iefremov previously approved these changes May 8, 2019
Copy link
Contributor

@iefremov iefremov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

riastradh-brave
riastradh-brave previously approved these changes May 8, 2019
SafeBrowsing checks in chromium send much more info than just IP and hashes.

See here: https://cs.chromium.org/chromium/src/components/safe_browsing/proto/csd.proto

Disabling SafeBrowsing in tor for now.

auditors: @iefremov, @riastradh-brave, @diracdeltas
@jumde jumde merged commit f681638 into master May 8, 2019
@jumde jumde added this to the 0.67.x - Nightly milestone May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabling SafeBrowsing in Tor
4 participants