Ads first launch notification timer no longer fires after notification dismissal #2371
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: brave/brave-browser#4180
A preference was added to mark whether the ads notification has gone away. The pref,
kBraveAdsHasDeletedFirstLaunchNotification
will be set to true if the user dismisses the notification, engages with the notification, enables ads, or if the notification goes away on its own after its 7 day timeout. This is used as the crutch to determine whether we need to initialize the timeout timer or not.Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security
) onnpm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
As there are no behavioral indicators that the deletion timer is still firing after the notification goes away, this will have to be confirmed via logging.
OnFirstLaunchNotificationTimedOut
does not start up.Reviewer Checklist:
After-merge Checklist:
changes has landed on.