Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable urllib3 full HTTP header logging via toggle #2339

Merged
merged 1 commit into from
Apr 25, 2019
Merged

Conversation

mbacchi
Copy link
Contributor

@mbacchi mbacchi commented Apr 24, 2019

This is disabled by default, enabled with the
environment variable DEBUG_HTTP_HEADERS

Fixes https://github.com/brave/devops/issues/911

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

This is disabled by default, enabled with the
environment variable DEBUG_HTTP_HEADERS

Fixes https://github.com/brave/devops/issues/911
@mbacchi mbacchi self-assigned this Apr 24, 2019
@mihaiplesa mihaiplesa added this to the 0.66.x - Nightly milestone Apr 25, 2019
Copy link
Collaborator

@mihaiplesa mihaiplesa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants