Code

Sync#226

Code

Merged

AlexeyBarabash merged 97 commits intomasterbrave/brave-core:masterfrom WIP_syncbrave/brave-core:WIP_syncCopy head branch name to clipboardNov 1, 2018

+9,245-14

Commits

Commits on Nov 1, 2018

• WIP branch. Rebasing Brave-sync to Chromium69

  Show description for 5f72a3e
  AlexeyBarabash

  committed
  5f72a3e

  Copy full SHA for 5f72a3e

• add sync extension to typescript exclusion list

  

  cezaraugusto

  authored and

  AlexeyBarabash

  committed
  8587c52

  Copy full SHA for 8587c52

• set sync to be locale-ready

  Show description for 42c69ca
  

  cezaraugusto

  authored and

  AlexeyBarabash

  committed
  42c69ca

  Copy full SHA for 42c69ca

• Pass base bookmark order when id == -1

  Show description for 5b2e4db
  

  darkdh

  authored and

  AlexeyBarabash

  committed
  5b2e4db

  Copy full SHA for 5b2e4db

• can send created bookmarks with order after sync initialization when there were no bookmarks

  Show description for a8461a0
  AlexeyBarabash

  committed
  a8461a0

  Copy full SHA for a8461a0

• Propagate parentFolderID correctly when

  Show description for 4732630
  

  darkdh

  authored and

  AlexeyBarabash

  committed
  4732630

  Copy full SHA for 4732630

• Make sure each bookmark is processed and save to object id map before

  Show description for fd9df0c
  

  darkdh

  authored and

  AlexeyBarabash

  committed
  fd9df0c

  Copy full SHA for fd9df0c

• removed some not actual TODOs

  AlexeyBarabash

  committed
  aeea601

  Copy full SHA for aeea601

• Cleanup

  Show description for e229cbd
  

  darkdh

  authored and

  AlexeyBarabash

  committed
  e229cbd

  Copy full SHA for e229cbd

• Pass weakptr for same sequence post task in ControllerImpl

  

  darkdh

  authored and

  AlexeyBarabash

  committed
  50f549e

  Copy full SHA for 50f549e

• modified brave-crypto DEPS '0.1.0'->'0.2.0'

  AlexeyBarabash

  committed
  4f0689e

  Copy full SHA for 4f0689e

• Fix BookmarkNodeRemoved for folder deletion

  

  darkdh

  authored and

  AlexeyBarabash

  committed
  bd568a9

  Copy full SHA for bd568a9

• controller -> brave_sync_service

  

  bridiver

  authored and

  AlexeyBarabash

  committed
  10b5157

  Copy full SHA for 10b5157

• more service, dep and thread cleanup

  

  bridiver

  authored and

  AlexeyBarabash

  committed
  f4e72bb

  Copy full SHA for f4e72bb

• fix device not being removed

  Show description for 43b904b
  

  cezaraugusto

  authored and

  AlexeyBarabash

  committed
  43b904b

  Copy full SHA for 43b904b

• properly initialize BraveSyncClientFactory

  

  bridiver

  authored and

  AlexeyBarabash

  committed
  2e20c79

  Copy full SHA for 2e20c79

• make sure all leveldb operations happen on the same thread

  

  bridiver

  authored and

  AlexeyBarabash

  committed
  c47615c

  Copy full SHA for c47615c

• sync_client -> brave_sync_client to match actual class name

  

  bridiver

  authored and

  AlexeyBarabash

  committed
  454037e

  Copy full SHA for 454037e

• fixes according to codereview notices

  AlexeyBarabash

  committed
  e18a8b5

  Copy full SHA for e18a8b5

• not synced records re-send support

  AlexeyBarabash

  committed
  a122377

  Copy full SHA for a122377

• removed testing constant parameter

  AlexeyBarabash

  committed
  44adf0c

  Copy full SHA for 44adf0c

• improve generateQRCodeImageSource

  Show description for 07cd6a5
  

  cezaraugusto

  authored and

  AlexeyBarabash

  committed
  07cd6a5

  Copy full SHA for 07cd6a5

• set sync this device and all sync data to return if input is undefined

  Show description for c4d346e
  

  cezaraugusto

  authored and

  AlexeyBarabash

  committed
  c4d346e

  Copy full SHA for c4d346e

• cleaned logging on extension background page

  AlexeyBarabash

  committed
  3f4d621

  Copy full SHA for 3f4d621

• fixed delete operation with unsynced items

  AlexeyBarabash

  committed
  465da0c

  Copy full SHA for 465da0c

• Load/Unload sync extension based on the value of kSyncThisDeviceEnabled

  Show description for 879144e
  

  darkdh

  authored and

  AlexeyBarabash

  committed
  879144e

  Copy full SHA for 879144e

• workaround to use C++ sync words => bytes conversion

  AlexeyBarabash

  committed
  11b9f2f

  Copy full SHA for 11b9f2f

• fixed send remove device record

  AlexeyBarabash

  committed
  fb830cc

  Copy full SHA for fb830cc

• reset sync by device itself if deleted from other

  AlexeyBarabash

  committed
  3a3a6b9

  Copy full SHA for 3a3a6b9

• updated DEPS to the latest brave/sync lib

  AlexeyBarabash

  committed
  05a2ff5

  Copy full SHA for 05a2ff5

• convert to bookmark meta info

  

  bridiver

  authored and

  AlexeyBarabash

  committed
  9ea0ab2

  Copy full SHA for 9ea0ab2

• use sync_timestamp to identify unsynced bookmarks

  Show description for d93864b
  

  bridiver

  authored and

  AlexeyBarabash

  committed
  d93864b

  Copy full SHA for d93864b

• fix shutdown destruction for sync_object_map_

  Show description for 297f025
  

  bridiver

  authored and

  AlexeyBarabash

  committed
  297f025

  Copy full SHA for 297f025

• get device resolving and fetch on latest record timestamp back

  AlexeyBarabash

  committed
  6758726

  Copy full SHA for 6758726

• Save seed only from SAVE_INIT_DATA also remove temp storage

  Show description for 2254893
  

  darkdh

  authored and

  AlexeyBarabash

  committed
  2254893

  Copy full SHA for 2254893

• Init SyncService in DoFinalInitForServices when sync is configured

  

  darkdh

  authored and

  AlexeyBarabash

  committed
  95d54f5

  Copy full SHA for 95d54f5

• set sync_timestamp in resolve

  Show description for c879d42
  

  bridiver

  authored and

  AlexeyBarabash

  committed
  c879d42

  Copy full SHA for c879d42

• 1. Fix next_node calculation when node is the last item, GetChild(index + 1) is illegal for last item

  Show description for 7254c74
  

  darkdh

  authored and

  AlexeyBarabash

  committed
  7254c74

  Copy full SHA for 7254c74

• fix typo and resulting DCHECK error

  Show description for 4b00aeb
  

  bridiver

  authored and

  AlexeyBarabash

  committed
  4b00aeb

  Copy full SHA for 4b00aeb

• Start/stop loop by extension reday/unloaded

  Show description for 9db1086
  

  darkdh

  authored and

  AlexeyBarabash

  committed
  9db1086

  Copy full SHA for 9db1086

• add parent_order for calculating get order api

  Show description for 3717e4f
  

  bridiver

  authored and

  AlexeyBarabash

  committed
  3717e4f

  Copy full SHA for 3717e4f

• parentOrder parameter for get/save bookmark order in background page

  AlexeyBarabash

  committed
  fe40545

  Copy full SHA for fe40545

• add parentNode to callback

  Show description for b96b6eb
  

  bridiver

  authored and

  AlexeyBarabash

  committed
  b96b6eb

  Copy full SHA for b96b6eb

• Send sync records at the end of bookmarks iterating

  

  darkdh

  authored and

  AlexeyBarabash

  committed
  8c4a7c7

  Copy full SHA for 8c4a7c7

• fix weakptr sequence checker crash

  

  bridiver

  authored and

  AlexeyBarabash

  committed
  e87c5a6

  Copy full SHA for e87c5a6

• stop the loop on shutdown

  

  bridiver

  authored and

  AlexeyBarabash

  committed
  b860a91

  Copy full SHA for b860a91

• Monitor kSyncThisDeviceEnabled change by PrefChangeRegistrar

  Show description for 7cc9f96
  

  darkdh

  authored and

  AlexeyBarabash

  committed
  7cc9f96

  Copy full SHA for 7cc9f96

• lint and other cleanup

  

  bridiver

  authored and

  AlexeyBarabash

  committed
  4a45763

  Copy full SHA for 4a45763

• Fix unsynchronized data between prefs and webui settings

  Show description for 29c212c
  

  darkdh

  authored and

  AlexeyBarabash

  committed
  29c212c

  Copy full SHA for 29c212c

• more lint and cleanup

  

  bridiver

  authored and

  AlexeyBarabash

  committed
  2cff586

  Copy full SHA for 2cff586

• cleanup pref names

  

  bridiver

  authored and

  AlexeyBarabash

  committed
  10f1b29

  Copy full SHA for 10f1b29

• use prefs for devices

  

  bridiver

  authored and

  AlexeyBarabash

  committed
  fe4b7d9

  Copy full SHA for fe4b7d9

• temporarily set sync_version back to 0

  

  bridiver

  authored and

  AlexeyBarabash

  committed
  f561314

  Copy full SHA for f561314

• devices -> sync_devices to match class name

  

  bridiver

  authored and

  AlexeyBarabash

  committed
  bf9eead

  Copy full SHA for bf9eead

• these aren't necessary anymore, we only need checks on public method calls

  

  bridiver

  authored and

  AlexeyBarabash

  committed
  e7d158e

  Copy full SHA for e7d158e

• clear out history stuff for now because we want to look at a different approach anyway

  

  bridiver

  authored and

  AlexeyBarabash

  committed
  5b66731

  Copy full SHA for 5b66731

• add missing sync_devices

  

  bridiver

  authored and

  AlexeyBarabash

  committed
  cb88944

  Copy full SHA for cb88944

• sync_client shouldn't be a keyed service

  

  bridiver

  authored and

  AlexeyBarabash

  committed
  d2a69e1

  Copy full SHA for d2a69e1

• don't need weak ptr anymore

  

  bridiver

  authored and

  AlexeyBarabash

  committed
  1059ad9

  Copy full SHA for 1059ad9

• cleanup deps

  

  bridiver

  authored and

  AlexeyBarabash

  committed
  41773b2

  Copy full SHA for 41773b2

• refactor bookmarks into BookmarkChangeProcessor

  

  bridiver

  authored and

  AlexeyBarabash

  committed
  05c7003

  Copy full SHA for 05c7003

• add change processor interface to start bringing things in line with chromium sync classes

  

  bridiver

  authored and

  AlexeyBarabash

  committed
  10e6176

  Copy full SHA for 10e6176

• updated DEPS for brave-sync lib to its main branch after merge branch PR

  AlexeyBarabash

  committed
  d8547c6

  Copy full SHA for d8547c6

• Implement FETCH_SYNC_DEVICES so that when "sync site setting" toggle is off, we can still sync new devices

  

  darkdh

  authored and

  AlexeyBarabash

  committed
  355896c

  Copy full SHA for 355896c

• Prevent users from turning on history, site settings until they are

  Show description for 9a49882
  

  darkdh

  authored and

  AlexeyBarabash

  committed
  9a49882

  Copy full SHA for 9a49882

• NotifySyncStateChanged cleanup

  Show description for 6ab5f74
  

  darkdh

  authored and

  AlexeyBarabash

  committed
  6ab5f74

  Copy full SHA for 6ab5f74

• wip sync unit test; can run test 1

  AlexeyBarabash

  committed
  5c94f4a

  Copy full SHA for 5c94f4a

• refactor classes to cleanup test setup code

  

  bridiver

  authored and

  AlexeyBarabash

  committed
  0dd5cf2

  Copy full SHA for 0dd5cf2

• add some missing assertions

  

  bridiver

  authored and

  AlexeyBarabash

  committed
  3641710

  Copy full SHA for 3641710

• fix rebase issues

  

  bridiver

  authored and

  AlexeyBarabash

  committed
  8de0f46

  Copy full SHA for 8de0f46

• updated brave sync lib DEPS

  AlexeyBarabash

  committed
  3d5e794

  Copy full SHA for 3d5e794

• pausing observer while applying changes from sync

  AlexeyBarabash

  committed
  5995298

  Copy full SHA for 5995298

• fix finding of parent when updating

  

  bridiver

  authored and

  AlexeyBarabash

  committed
  68b7355

  Copy full SHA for 68b7355

• we're skipping the observer method so these bookmarks should already have an order value

  

  bridiver

  authored and

  AlexeyBarabash

  committed
  50e139a

  Copy full SHA for 50e139a

• pause the sync loop when waiting for an order response so new records don't come in and override in-progress local changes

  

  bridiver

  authored and

  AlexeyBarabash

  committed
  ac2db42

  Copy full SHA for ac2db42

• try to avoid overwriting remote sync data with unchanged local data

  

  bridiver

  authored and

  AlexeyBarabash

  committed
  95d310b

  Copy full SHA for 95d310b

• this seems more reliable

  

  bridiver

  authored and

  AlexeyBarabash

  committed
  2f348a5

  Copy full SHA for 2f348a5

• cleanup

  

  bridiver

  authored and

  AlexeyBarabash

  committed
  c144627

  Copy full SHA for c144627

• Don't put changes records from sync model to unsync lists

  Show description for 14063af
  

  darkdh

  authored and

  AlexeyBarabash

  committed
  14063af

  Copy full SHA for 14063af

• bookmark_change_processor_unittest; matcher for send record; sync client mock in separate file

  AlexeyBarabash

  committed
  3682708

  Copy full SHA for 3682708

• cleanup

  AlexeyBarabash

  committed
  cdf4306

  Copy full SHA for cdf4306

• don't keep static vars for per-profile attributes

  

  bridiver

  authored and

  AlexeyBarabash

  committed
  6480555

  Copy full SHA for 6480555

• fixing tests

  Show description for 28062ef
  AlexeyBarabash

  committed
  28062ef

  Copy full SHA for 28062ef

• Obtain order when "SEND_SYNC_RECORDS" and "RESOLVE_SYNC_RECORDS" to sync library

  Show description for a4f6851
  

  darkdh

  authored and

  AlexeyBarabash

  committed
  a4f6851

  Copy full SHA for a4f6851

• cleaned some unused code

  AlexeyBarabash

  committed
  fa33db2

  Copy full SHA for fa33db2

• more bookmark_change_processor tests

  Show description for b7d740f
  AlexeyBarabash

  committed
  b7d740f

  Copy full SHA for b7d740f

• clearing order for shifted nodes when moving

  

  darkdh

  authored and

  AlexeyBarabash

  committed
  c1f5e79

  Copy full SHA for c1f5e79

• Fix syncTimestamp propagation

  Show description for 03a2a79
  

  darkdh

  authored and

  AlexeyBarabash

  committed
  03a2a79

  Copy full SHA for 03a2a79

• added new and adapted existing test to new resolve records way

  AlexeyBarabash

  committed
  1f1aff4

  Copy full SHA for 1f1aff4

• GetTaskRunnerForThread removal (C71 upgrade)

  Show description for 33af016
  

  darkdh

  authored and

  AlexeyBarabash

  committed
  33af016

  Copy full SHA for 33af016

• more BraveSyncService tests

  AlexeyBarabash

  committed
  753b75b

  Copy full SHA for 753b75b

• command line key to enable use of sync, disabled by default

  AlexeyBarabash

  committed
  d7823ab

  Copy full SHA for d7823ab

• Address review comments

  Show description for cf5f057
  

  darkdh

  authored and

  AlexeyBarabash

  committed
  cf5f057

  Copy full SHA for cf5f057

• ts lint

  

  darkdh

  authored and

  AlexeyBarabash

  committed
  045518d

  Copy full SHA for 045518d

• removed BraveSyncServiceObserver::OnLogMessage because it just sends message to console log, according to codereview

  AlexeyBarabash

  committed
  eb93cac

  Copy full SHA for eb93cac

• Fix build on Windows

  Show description for 30cd566
  

  darkdh

  authored and

  AlexeyBarabash

  committed
  30cd566

  Copy full SHA for 30cd566

• fix of incorrect sync initialization with wrong code words

  AlexeyBarabash

  committed
  c5853d8

  Copy full SHA for c5853d8