Merge pull request #1840 from brave/sync_deps_sorting #1844
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uplift of #1840 into 0.61.x (beta)
This is the last channel I would like to uplift this PR to. Will not uplift to stable to avoid unexpected side-effects.
Fixes brave/brave-browser#3515 .
New sync lib head commit for DEPS is brave/sync@76bf8f1 .
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests
) onnpm run lint
) - I see a lot of unrelated warnings.git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
The STR from brave/brave-browser#3515
brave://bookmarks/
https://www.bing.com/search?q=BCA-01&qs=n&form=QBLH&sp=-1&pq=bca-01&sc=8-6&sk=&cvid=4CE2DC7674794F3C89E4F55DE31BBD2A
https://www.bing.com/search?q=BCA-02&qs=n&form=QBRE&sp=-1&pq=bca-02&sc=8-6&sk=&cvid=DA80C45365A54CF4880E4F853CE72332
https://www.bing.com/search?q=BCA-03&qs=n&form=QBRE&sp=-1&pq=bca-03&sc=8-6&sk=&cvid=5E00C210D471463EB9ECF64D9EC703DA
BCA-01
andBCA-02
as quick as possibleBCA-01
andBCA-02
appear. When this happened as quick as possible, on device A unbookmarkBCA-02
tab and bookmarkBCA-03
tabBCA-02
is removedReviewer Checklist: