Don't add brave url to history #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridiver
reviewed
Mar 2, 2019
| #include "url/gurl.h" | ||
|
|
||
| TEST(HistoryUtilsTest, BraveUISchemeTest) { | ||
| EXPECT_FALSE(CanAddURLToHistory(GURL("brave://sync/"))); |
There was a problem hiding this comment.
can we add some urls that should be added to history? Want to make sure that someone doesn't accidentally break this to return false for everything
There was a problem hiding this comment.
also some urls that should not be added based on the ChromiumImpl method?
There was a problem hiding this comment.
I think we don't need to to check many urls because CanAddURLToHistory() just checks scheme.
There was a problem hiding this comment.
Ah, I see what you mean. will add more urls
bridiver
reviewed
Mar 2, 2019
| #undef CanAddURLToHistory | ||
|
|
||
| bool CanAddURLToHistory(const GURL& url) { | ||
| if (!url.is_valid()) |
There was a problem hiding this comment.
do we actually need this? Can we just let CanAddURLToHistory_ChromiumImpl handle anything like that?
simonhong
force-pushed
the
dont_add_brave_url_to_history
branch
4 times, most recently
from
924b728 to
e2c8054
Compare
Added test for this change: HistoryUtilsTest.VariousURLTest
simonhong
force-pushed
the
dont_add_brave_url_to_history
branch
from
e2c8054 to
3721c79
Compare
bridiver
approved these changes
Mar 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix brave/brave-browser#3493
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) onnpm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
yarn test brave_unit_tests --filter=HistoryUtilsTest.*Reviewer Checklist: