Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only create a SKU transaction if there doesn't already exist one. (uplift to 1.50.x) #17669

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Only create a SKU transaction if there doesn't already exist one. (uplift to 1.50.x) #17669

merged 1 commit into from
Mar 24, 2023

Conversation

szilardszaloki
Copy link
Collaborator

@szilardszaloki szilardszaloki commented Mar 20, 2023 •
edited by kjozwiak
Loading

Uplift of #17644
Resolves brave/brave-browser#29089

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@szilardszaloki szilardszaloki requested a review from a team as a code owner March 20, 2023 12:53
@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@szilardszaloki szilardszaloki force-pushed the pr17644_sszaloki-29089-fixes-ac-retries_1.50.x branch from a202e2e to 5388044 Compare March 20, 2023 17:52
@kjozwiak kjozwiak added this to the 1.50.x - Beta milestone Mar 24, 2023
kjozwiak
kjozwiak approved these changes Mar 24, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.50.x approved 👍 QA has verified the PR on Nightly as per #17644 (comment).

@kjozwiak kjozwiak merged commit 45188c8 into 1.50.x Mar 24, 2023
@kjozwiak kjozwiak deleted the pr17644_sszaloki-29089-fixes-ac-retries_1.50.x branch March 24, 2023 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@szilardszaloki szilardszaloki

Labels
None yet
Projects
None yet
Milestone
1.50.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@szilardszaloki @kjozwiak