Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Wallet) Implement NFT asset details screen #16671

Merged
merged 15 commits into from
Jan 24, 2023
Merged

(Wallet) Implement NFT asset details screen #16671

merged 15 commits into from
Jan 24, 2023

Commits on Jan 24, 2023

  1. Make inner classes static 

    Improve performance and (more importantly) fix serialization as inner classes hold a reference to their outer class when non-static.
    @simoarpe
    simoarpe committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    9b95377 View commit details
    Browse the repository at this point in the history

  2. Make ImageLoader helper method more flexible

    @simoarpe
    simoarpe committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    27e4fef View commit details
    Browse the repository at this point in the history

  3. Add new strings required for NFT Detail screen

    @simoarpe
    simoarpe committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    0790df7 View commit details
    Browse the repository at this point in the history

  4. New helper method to calculate screen height

    @simoarpe
    simoarpe committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    e248e2c View commit details
    Browse the repository at this point in the history

  5. New NFT Detail activity layout

    @simoarpe
    simoarpe committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    1d56e2d View commit details
    Browse the repository at this point in the history

  6. Add new NftDetailActivity

    @simoarpe
    simoarpe committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    99e500b View commit details
    Browse the repository at this point in the history

  7. Open NFT Detail activity when NFT is tapped

    @simoarpe
    simoarpe committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    f09a576 View commit details
    Browse the repository at this point in the history

  8. Address review feedback

    @simoarpe
    simoarpe committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    f6c69d2 View commit details
    Browse the repository at this point in the history

  9. Update NftDetailActivity.java

    @simoarpe
    simoarpe committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    10b2b70 View commit details
    Browse the repository at this point in the history

  10. Update NftDetailActivity.java

    @simoarpe
    simoarpe committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    6b75bae View commit details
    Browse the repository at this point in the history

  11. Apply formatting

    @simoarpe
    simoarpe committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    aca0eab View commit details
    Browse the repository at this point in the history

  12. Address review feedback

    @simoarpe
    simoarpe committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    0903fac View commit details
    Browse the repository at this point in the history

  13. Observe NFT data models

    @simoarpe
    simoarpe committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    5c789e6 View commit details
    Browse the repository at this point in the history

  14. Improve URL check 

    Makes sure the URL is a data URL that starts with `data:`, or a network URL that starts with `http` or `https`.
    @simoarpe
    simoarpe committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    81e7681 View commit details
    Browse the repository at this point in the history

  15. Address security review feedback

    @simoarpe
    simoarpe committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    b97dc59 View commit details
    Browse the repository at this point in the history