Ads Confirmations #1645
Merged
Ads Confirmations #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridiver
reviewed
Feb 12, 2019
| @@ -17,6 +17,8 @@ | |||
| #include "bat/ads/ads_client.h" | |||
| #include "brave/components/brave_ads/browser/ads_service.h" | |||
| #include "brave/components/brave_ads/browser/background_helper.h" | |||
| #include "brave/components/brave_rewards/browser/rewards_service.h" | |||
There was a problem hiding this comment.
these headers should go in the .cc file - there is already a forward decl below for RewardsService
bridiver
reviewed
Feb 12, 2019
| @@ -297,14 +297,29 @@ void RewardsNotificationServiceImpl::OnGetAllNotifications( | |||
| TriggerOnGetAllNotifications(rewards_notifications_list); | |||
| } | |||
|
|
|||
| std::string RewardsNotificationServiceImpl::GetGrantIdPrefix( | |||
| const std::string& grant_type) { | |||
| std::string prefix = grant_type == "ugp" | |||
There was a problem hiding this comment.
grant_type == "ugp" should be a method to remove duplication
bridiver
reviewed
Feb 12, 2019
| @@ -21,6 +21,11 @@ | |||
| class PrefRegistrySimple; | |||
| class Profile; | |||
|
|
|||
| namespace ads { | |||
bridiver
reviewed
Feb 12, 2019
| @@ -182,6 +182,25 @@ class RewardsServiceImpl : public RewardsService, | |||
|
|
|||
| void GetAddressesForPaymentId(const GetAddressesCallback& callback) override; | |||
|
|
|||
| void SetCatalogIssuers(const std::string& json) override; | |||
There was a problem hiding this comment.
these should all be listed under // LedgerClient impl
There was a problem hiding this comment.
Just checked, and it is now listed under so I gather you made this change
bridiver
reviewed
Feb 12, 2019
tmancey
force-pushed
the
fix-linking-error-rebase
branch
from
6421522 to
be685ae
Compare
tmancey
force-pushed
the
fix-linking-error-rebase
branch
2 times, most recently
from
ce09db9 to
23226ee
Compare
ryanml
force-pushed
the
fix-linking-error-rebase
branch
from
6c9a062 to
268c810
Compare
This was referenced Feb 15, 2019
|
@ryanml when everything is done from UI perspective please let me know so that I can do a review of it. Please do not merge until I do that. Thank you |
tmancey
force-pushed
the
fix-linking-error-rebase
branch
from
9077d15 to
4f7be73
Compare
16 tasks
tmancey
force-pushed
the
fix-linking-error-rebase
branch
6 times, most recently
from
a4f3c9c to
f5447d7
Compare
NejcZdovc
force-pushed
the
fix-linking-error-rebase
branch
from
8fd1062 to
5ff0738
Compare
This was referenced Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes brave/brave-browser#3117
fixes brave/brave-browser#2830
fixes brave/brave-browser#2912
fixes brave/brave-browser#2910
fixes brave/brave-browser#2909
fixes brave/brave-browser#2908
fixes brave/brave-browser#2907
fixes brave/brave-browser#2906
requires brave/brave-browser#3406
requires brave-intl/bat-native-confirmations#67
requires #1751
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) ongit rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: