Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable reduce language feature by default (uplift to 1.41.x) #13911

Merged
merged 1 commit into from
Jun 24, 2022
Merged

Disable reduce language feature by default (uplift to 1.41.x) #13911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions browser/farbling/brave_navigator_languages_farbling_browsertest.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
#include "third_party/blink/renderer/core/frame/navigator_language.h"

using brave_shields::ControlType;
using brave_shields::features::kBraveReduceLanguage;
using content::TitleWatcher;

namespace {
Expand All @@ -48,6 +49,7 @@ class BraveNavigatorLanguagesFarblingBrowserTest : public InProcessBrowserTest {
public:
BraveNavigatorLanguagesFarblingBrowserTest()
: https_server_(net::EmbeddedTestServer::TYPE_HTTPS) {
feature_list_.InitAndEnableFeature(kBraveReduceLanguage);
brave::RegisterPathProvider();
base::FilePath test_data_dir;
base::PathService::Get(brave::DIR_TEST_DATA, &test_data_dir);
Expand Down
2 changes: 1 addition & 1 deletion components/brave_shields/common/features.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ const base::Feature kBraveExtensionNetworkBlocking{
"BraveExtensionNetworkBlocking", base::FEATURE_DISABLED_BY_DEFAULT};
// When enabled, language headers and APIs may be altered by Brave Shields.
const base::Feature kBraveReduceLanguage{"BraveReduceLanguage",
base::FEATURE_ENABLED_BY_DEFAULT};
base::FEATURE_DISABLED_BY_DEFAULT};
// When enabled, Brave will always report Light in Fingerprinting: Strict mode
const base::Feature kBraveDarkModeBlock{"BraveDarkModeBlock",
base::FEATURE_ENABLED_BY_DEFAULT};
Expand Down