Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wallet usage ping parameter after updating to 1.36.x (uplift to 1.36.x) #12496

Merged
merged 1 commit into from
Mar 6, 2022
Merged

Fix wallet usage ping parameter after updating to 1.36.x (uplift to 1.36.x) #12496

merged 1 commit into from
Mar 6, 2022

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Mar 5, 2022 •
edited by kjozwiak
Loading

Uplift of #12488

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner March 5, 2022 00:02
@brave-builds brave-builds requested a review from a team March 5, 2022 00:02
@brave-builds brave-builds self-assigned this Mar 5, 2022
@brave-builds brave-builds added this to the 1.36.x - Release #2 milestone Mar 5, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Mar 5, 2022

Restarting macOS as there were issues with both test-unit & test-browser as per https://ci.brave.com/job/pr-brave-browser-pr12488_wallet-ping-update-fix_1.36.x-macos/1/testReport/.

kjozwiak
kjozwiak approved these changes Mar 6, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.36.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #12488 (comment).

@kjozwiak kjozwiak merged commit 433edd2 into 1.36.x Mar 6, 2022
@kjozwiak kjozwiak deleted the pr12488_wallet-ping-update-fix_1.36.x branch March 6, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.36.x - Release #2
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @brave-browser-releases