Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update strings in Sync #1245

Merged
merged 1 commit into from
Jan 8, 2019
Merged

Update strings in Sync #1245

merged 1 commit into from
Jan 8, 2019

Conversation

rossmoody
Copy link
Contributor

Update strings in Sync
sibling pr on master: #1242

@rossmoody rossmoody requested a review from cezaraugusto January 7, 2019 19:01
@cezaraugusto cezaraugusto requested review from rebron, bsclifton, kjozwiak, srirambv and bbondy and removed request for cezaraugusto January 7, 2019 21:02
@cezaraugusto cezaraugusto changed the title Merge pull request #1242 from brave/sync-strings Update strings in Sync Jan 7, 2019
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 0.59.x approved after deliberating with @rebron and @bsclifton 👍Please ensure that all appropriate issue(s) are moved into the correct milestone.

@cezaraugusto cezaraugusto merged commit 997388a into 0.59.x Jan 8, 2019
@cezaraugusto cezaraugusto deleted the sync-strings-59 branch January 8, 2019 16:37
@bbondy bbondy added this to the 0.59.x - Beta milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants