-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent duplicate nodes from reconnect and refine reset to make sure deleted record is sent #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deleted record is sent
AlexeyBarabash
approved these changes
Dec 19, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
This PR also addresses https://github.com/brave/browser-android-tabs/issues/924 . |
darkdh
added a commit
that referenced
this pull request
Dec 19, 2018
Prevent duplicate nodes from reconnect and refine reset to make sure deleted record is sent
Deliberated with @kjozwiak. Marking approved for uplift to 59.x |
darkdh
added a commit
that referenced
this pull request
Dec 19, 2018
Prevent duplicate nodes from reconnect and refine reset to make sure deleted record is sent
0.59.x: ddede29 |
24 tasks
24 tasks
This was referenced Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kSyncPrevSeed
is saved when reset and then will be clear during OnSaveInitData for create/connect sync chainResetSyncInternal
is introduced for making sure the final delete record is sent and resolved.fix brave/brave-browser#2443
fix brave/brave-browser#2527
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests
) ongit rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist: