Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shows grant notification only once #1132

Merged
merged 1 commit into from
Dec 20, 2018
Merged

Shows grant notification only once #1132

merged 1 commit into from
Dec 20, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Dec 18, 2018 •
edited
Loading

Resolves brave/brave-browser#2454

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • clean profile
  • open panel
  • enable rewards
  • make sure that you see grant notification
  • click on X
  • close panel
  • open panel again and make sure that you don't see notification again

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@NejcZdovc NejcZdovc self-assigned this Dec 18, 2018
@NejcZdovc NejcZdovc force-pushed the only-once branch 2 times, most recently from 8a28d02 to 0847365 Compare December 20, 2018 07:12
@NejcZdovc NejcZdovc requested a review from emerick December 20, 2018 07:15
emerick
emerick approved these changes Dec 20, 2018
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NejcZdovc NejcZdovc merged commit ed5c182 into master Dec 20, 2018
@NejcZdovc NejcZdovc deleted the only-once branch December 20, 2018 19:52
NejcZdovc added a commit that referenced this pull request Dec 20, 2018
@NejcZdovc
Merge pull request #1132 from brave/only-once
c06a80e 
Shows grant notification only once
@NejcZdovc
Copy link
Contributor Author

NejcZdovc commented Dec 20, 2018 •
edited
Loading

master (0.61) ed5c182
0.60 c06a80e
0.59 3204f56

@rebron
Copy link
Collaborator

rebron commented Dec 20, 2018

Approving uplift-request for 0.59.x-beta. cc: @kjozwiak cc: @srirambv

@NejcZdovc
Copy link
Contributor Author

@rebron to uplift this one we would need this one in as well #1107. Will add request for that one as well

NejcZdovc added a commit that referenced this pull request Dec 22, 2018
@NejcZdovc
Merge pull request #1132 from brave/only-once
3204f56 
Shows grant notification only once
@bbondy bbondy added this to the 0.59.x - Beta milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emerick emerick emerick approved these changes

Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards
Projects
None yet
Milestone
0.59.x - Release
Development

Successfully merging this pull request may close these issues.

Grant notification shows up too often (follow up to #1798)
4 participants
@NejcZdovc @rebron @emerick @bbondy