show message about server error when sync is active #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkdh
reviewed
Dec 18, 2018
| @@ -111,6 +111,10 @@ export default class SyncEnabledContent extends React.PureComponent<Props, State | |||
| }) | |||
| } | |||
|
|
|||
| onUserNoticedError = () => { | |||
| this.props.actions.resetSyncSetupError() | |||
There was a problem hiding this comment.
SYNC_RESET_SETUP_ERROR, this naming is confusing. what exactly is it related to reset?
There was a problem hiding this comment.
this dispatches a message cleaning up the error message (store receives undefined)
There was a problem hiding this comment.
per discussion in DM, please do a follow-up for better naming of this every where.
darkdh
approved these changes
Dec 18, 2018
cezaraugusto
added a commit
that referenced
this pull request
Dec 18, 2018
show message about server error when sync is active
darkdh
pushed a commit
that referenced
this pull request
Dec 20, 2018
show message about server error when sync is active
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix brave/brave-browser#2577
Test Plan:
This also adds the internet connection error