Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in add funds dialog #1070

Merged
merged 1 commit into from
Dec 12, 2018
Merged

Fix typo in add funds dialog #1070

merged 1 commit into from
Dec 12, 2018

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Dec 12, 2018 •
edited
Loading

cryto -> crypto

Fix brave/brave-browser#2474

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Check crypto is used instead of cryto.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@simonhong simonhong self-assigned this Dec 12, 2018
@simonhong simonhong requested a review from NejcZdovc December 12, 2018 06:26
@rebron
Copy link
Collaborator

rebron commented Dec 12, 2018

@simonhong can you start merging this to master/dev and request approval for beta. We want this in for 58.x.

@bbondy bbondy merged commit d8f2ab7 into master Dec 12, 2018
bbondy added a commit that referenced this pull request Dec 12, 2018
@bbondy
Merge pull request #1070 from brave/fix_typo_in_add_fund_dialog
40557f2 
Fix typo in add funds dialog
bbondy added a commit that referenced this pull request Dec 12, 2018
@bbondy
Merge pull request #1070 from brave/fix_typo_in_add_fund_dialog
96faf7e 
Fix typo in add funds dialog
bbondy added a commit that referenced this pull request Dec 12, 2018
@bbondy
Merge pull request #1070 from brave/fix_typo_in_add_fund_dialog
87731f5 
Fix typo in add funds dialog
@bbondy
Copy link
Member

bbondy commented Dec 12, 2018

master (0.61.x): d8f2ab7
0.60.x: 40557f2
0.59.x: 96faf7e
0.58.x: 87731f5

@NejcZdovc NejcZdovc deleted the fix_typo_in_add_fund_dialog branch December 12, 2018 20:45
@bbondy bbondy added this to the 0.58.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NejcZdovc NejcZdovc NejcZdovc approved these changes

Assignees

@simonhong simonhong

Labels
feature/rewards
Projects
None yet
Milestone
0.58.x - Release
Development

Successfully merging this pull request may close these issues.

fix typo in add-funds dialog text
4 participants
@simonhong @rebron @bbondy @NejcZdovc