-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hidden renderer for fetching backup search results #43399
Closed
DJAndries opened this issue
Jan 21, 2025
· 3 comments
· Fixed by brave/brave-core#27285 or brave/brave-core#27368
Closed
Add hidden renderer for fetching backup search results #43399
DJAndries opened this issue
Jan 21, 2025
· 3 comments
· Fixed by brave/brave-core#27285 or brave/brave-core#27368
Labels
feature/search
feature/web-discovery
OS/Android
Fixes related to Android browser functionality
OS/Desktop
QA Pass - Android ARM
QA Pass-Win64
QA/Yes
release-notes/exclude
Milestone
Comments
DJAndries
added
feature/search
feature/web-discovery
OS/Android
Fixes related to Android browser functionality
OS/Desktop
QA/Yes
release-notes/exclude
labels
Jan 21, 2025
24 tasks
Merged
7 tasks
This was referenced Jan 27, 2025
Merged
brave-builds
modified the milestones:
1.76.x - Nightly,
1.75.x - Beta,
1.74.x - Release #4
Jan 28, 2025
The above requires |
Verification PASSED on
|
Example |
Example |
Example |
Example |
---|---|---|---|
Test Case #2
- Web Discovery on Desktop
Using the STR/Cases mentioned via brave/brave-core#27285 (comment), ensured that:
- enabled
WDP
viabrave://settings/search
- visited
brave://inspect
and clicked onInspect
viaBrave chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/_generated_background_page.html
- within
Dev Tools
via theConsole
, pasted the following and waited ~10s:
WDP.modules['web-discovery-project'].background.webDiscoveryProject.patternsLoader.resourceWatcher.forceUpdate()
- visited/accessed https://www.google.com/search?q=this+is+a+test+query and then closed the tab
- waited ~20s and cleared the current log via Fiddler and then pasted the following into the
Console
as per the following:
WDP.modules['web-discovery-project'].background.webDiscoveryProject.strictQueries.map(x=>x.tDiff=0)
- waited ~10s and ensured there was two
google.com
requests logged with the second being over50kbs
Example |
Example |
Example |
---|---|---|
hffvld
added
the
QA/In-Progress
Indicates that QA is currently in progress for that particular issue
label
Jan 29, 2025
Verified on
STEPS:
ACTUAL RESULTS:
|
hffvld
added
QA Pass - Android ARM
and removed
QA/In-Progress
Indicates that QA is currently in progress for that particular issue
labels
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/search
feature/web-discovery
OS/Android
Fixes related to Android browser functionality
OS/Desktop
QA Pass - Android ARM
QA Pass-Win64
QA/Yes
release-notes/exclude
In order to fetch search results from backup providers anonymously, a hidden renderer must be embedded to execute the scripts required to render the results. The renderer will use an off-the-record profile for briefly preserving cookie state, which will be subsequently destroyed shortly after the results have been rendered/fetched.
If a user is opted in to Web Discovery or Brave Search fallback mixing, the hidden renderer will be used to fetch the results anonymously.
The text was updated successfully, but these errors were encountered: