Merge pull request #701 from diracdeltas/fix/binance-captcha

Add referer exception for geetest captchas
brave · Oct 21, 2018 · aea4680 · aea4680
1 parent 0209b45
commit aea4680
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/common/shield_exceptions.cc b/common/shield_exceptions.cc
@@ -98,6 +98,7 @@ bool IsWhitelistedReferrer(const GURL& firstPartyOrigin,
   // It's preferred to use specific_patterns below when possible
   static std::vector<URLPattern> whitelist_patterns({
     URLPattern(URLPattern::SCHEME_ALL, "https://use.typekit.net/*"),
+    URLPattern(URLPattern::SCHEME_ALL, "https://api.geetest.com/*"),
     URLPattern(URLPattern::SCHEME_ALL, "https://cloud.typography.com/*")
   });
   return std::any_of(whitelist_patterns.begin(), whitelist_patterns.end(),

diff --git a/common/shield_exceptions_unittest.cc b/common/shield_exceptions_unittest.cc
@@ -71,6 +71,14 @@ TEST_F(BraveShieldsExceptionsTest, IsWhitelistedReferrer) {
       GURL("https://use.typekit.net/193")));
   EXPECT_TRUE(IsWhitelistedReferrer(GURL("https://www.test.com"),
       GURL("https://cloud.typography.com/199")));
+  // geetest allowed everywhere
+  EXPECT_TRUE(IsWhitelistedReferrer(GURL("https://binance.com"),
+      GURL("https://api.geetest.com/ajax.php?")));
+  EXPECT_TRUE(IsWhitelistedReferrer(GURL("http://binance.com"),
+      GURL("https://api.geetest.com/")));
+  // not allowed with a different scheme
+  EXPECT_FALSE(IsWhitelistedReferrer(GURL("http://binance.com"),
+      GURL("http://api.geetest.com/")));
 }
 
 }  // namespace