-
Notifications
You must be signed in to change notification settings - Fork 862
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixed not being able to exit brave wallet using navigation (#16911)
Uplift of #16877 (squashed) to release
- Loading branch information
Pavneet Singh
committed
Jan 31, 2023
1 parent
d0bac6e
commit 7cf1f9d
Showing
5 changed files
with
95 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63 changes: 63 additions & 0 deletions
63
android/java/org/chromium/chrome/browser/app/helpers/Api33AndPlusBackPressHelper.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
/* Copyright (c) 2023 The Brave Authors. All rights reserved. | ||
* This Source Code Form is subject to the terms of the Mozilla Public | ||
* License, v. 2.0. If a copy of the MPL was not distributed with this file, | ||
* You can obtain one at https://mozilla.org/MPL/2.0/. */ | ||
|
||
package org.chromium.chrome.browser.app.helpers; | ||
|
||
import android.os.Build; | ||
import android.window.OnBackInvokedCallback; | ||
import android.window.OnBackInvokedDispatcher; | ||
|
||
import androidx.annotation.NonNull; | ||
import androidx.annotation.RequiresApi; | ||
import androidx.fragment.app.FragmentActivity; | ||
import androidx.lifecycle.DefaultLifecycleObserver; | ||
import androidx.lifecycle.LifecycleOwner; | ||
|
||
import java.lang.ref.WeakReference; | ||
|
||
/** | ||
* Helper class for back press event handling via {@link OnBackInvokedDispatcher}. | ||
* This should only be used to resolve Android 13+ back press issue | ||
* {@link https://github.com/brave/brave-browser/issues/27787}. | ||
*/ | ||
public final class Api33AndPlusBackPressHelper { | ||
private final WeakReference<FragmentActivity> mActivity; | ||
|
||
@RequiresApi(api = Build.VERSION_CODES.TIRAMISU) | ||
public static void create(LifecycleOwner lifecycleOwner, FragmentActivity activity, | ||
OnBackInvokedCallback handler) { | ||
new Api33AndPlusBackPressHelper(lifecycleOwner, activity, handler); | ||
} | ||
|
||
private Api33AndPlusBackPressHelper(LifecycleOwner lifecycleOwner, FragmentActivity activity, | ||
OnBackInvokedCallback handler) { | ||
mActivity = new WeakReference<>(activity); | ||
if (isActive() && Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) { | ||
getRef().getOnBackInvokedDispatcher().registerOnBackInvokedCallback( | ||
OnBackInvokedDispatcher.PRIORITY_DEFAULT, handler); | ||
lifecycleOwner.getLifecycle().addObserver(new DefaultLifecycleObserver() { | ||
@Override | ||
public void onDestroy(@NonNull LifecycleOwner owner) { | ||
if (isAvailable()) { | ||
getRef().getOnBackInvokedDispatcher().unregisterOnBackInvokedCallback( | ||
handler); | ||
} | ||
} | ||
}); | ||
} | ||
} | ||
|
||
private FragmentActivity getRef() { | ||
return mActivity.get(); | ||
} | ||
|
||
private boolean isAvailable() { | ||
return mActivity != null && mActivity.get() != null; | ||
} | ||
|
||
private boolean isActive() { | ||
return isAvailable() && !mActivity.get().isFinishing(); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters