-
Notifications
You must be signed in to change notification settings - Fork 900
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Patches ChromeCrashReporterClient::GetCollectStatsConsent to check for BRAVE_CHROMIUM_BUILD in addition to GOOGLE_CHROME_BUILD. - Patches breakpad Linux implementation with Brave's crash reporting upload endpoint. Fixes brave/brave-browser#1251
- Loading branch information
Showing
2 changed files
with
30 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
diff --git a/chrome/app/chrome_crash_reporter_client.cc b/chrome/app/chrome_crash_reporter_client.cc | ||
index 941caaa910906af473915f444fbbd2b4a9abe4d1..9606df6b5f8bb76acd4b8cf0cea6c58215ffb779 100644 | ||
--- a/chrome/app/chrome_crash_reporter_client.cc | ||
+++ b/chrome/app/chrome_crash_reporter_client.cc | ||
@@ -110,7 +110,7 @@ bool ChromeCrashReporterClient::IsRunningUnattended() { | ||
} | ||
|
||
bool ChromeCrashReporterClient::GetCollectStatsConsent() { | ||
-#if defined(GOOGLE_CHROME_BUILD) | ||
+#if defined(GOOGLE_CHROME_BUILD) || (defined(BRAVE_CHROMIUM_BUILD) && defined(OFFICIAL_BUILD)) | ||
bool is_official_chrome_build = true; | ||
#else | ||
bool is_official_chrome_build = false; |
17 changes: 17 additions & 0 deletions
17
patches/components-crash-content-app-breakpad_linux.cc.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
diff --git a/components/crash/content/app/breakpad_linux.cc b/components/crash/content/app/breakpad_linux.cc | ||
index a7378204ffaa5586be9789a552de0f2a951ad208..9044ab8c9bb148edba86cad6b9781c726ad6dfed 100644 | ||
--- a/components/crash/content/app/breakpad_linux.cc | ||
+++ b/components/crash/content/app/breakpad_linux.cc | ||
@@ -88,8 +88,12 @@ namespace breakpad { | ||
namespace { | ||
|
||
#if !defined(OS_CHROMEOS) | ||
+#if defined(BRAVE_CHROMIUM_BUILD) | ||
+const char kUploadURL[] = "https://laptop-updates.brave.com/1/bc-crashes"; | ||
+#else | ||
const char kUploadURL[] = "https://clients2.google.com/cr/report"; | ||
#endif | ||
+#endif | ||
|
||
bool g_is_crash_reporter_enabled = false; | ||
uint64_t g_process_start_time = 0; |