Removes balance api calls for 0 balance

Resolves brave/brave-browser#9132

components/brave_rewards/browser/rewards_service.cc

@@ -92,6 +92,7 @@ void RewardsService::RegisterProfilePrefs(PrefRegistrySimple* registry) {
       "");
   registry->RegisterStringPref(prefs::kStateParametersTipChoices, "");
   registry->RegisterStringPref(prefs::kStateParametersMonthlyTipChoices, "");
+  registry->RegisterBooleanPref(prefs::kStateFetchOldBalance, true);
 }
 
 }  // namespace brave_rewards

components/brave_rewards/common/pref_names.cc

@@ -62,5 +62,7 @@ const char kStateParametersTipChoices[] =
     "brave.rewards.parameters.tip.choices";
 const char kStateParametersMonthlyTipChoices[] =
     "brave.rewards.parameters.tip.monthly_choices";
+const char kStateFetchOldBalance[] =
+    "brave.rewards.fetch_old_balance";
 }  // namespace prefs
 }  // namespace brave_rewards

components/brave_rewards/common/pref_names.h

@@ -50,6 +50,7 @@ extern const char kStateParametersAutoContributeChoice[];
 extern const char kStateParametersAutoContributeChoices[];
 extern const char kStateParametersTipChoices[];
 extern const char kStateParametersMonthlyTipChoices[];
+extern const char kStateFetchOldBalance[];
 
 extern const char kUseRewardsStagingServer[];
 }  // namespace prefs

vendor/bat-native-ledger/src/bat/ledger/internal/state/state_keys.h

@@ -41,6 +41,7 @@ namespace ledger {
   const char kStateParametersTipChoices[] = "parameters.tip.choices";
   const char kStateParametersMonthlyTipChoices[] =
       "parameters.tip.monthly_choices";
+  const char kStateFetchOldBalance[] = "fetch_old_balance";
 
 }  // namespace ledger
 

vendor/bat-native-ledger/src/bat/ledger/internal/state/state_util.cc

@@ -355,4 +355,14 @@ std::vector<double> GetMonthlyTipChoices(bat_ledger::LedgerImpl* ledger) {
   return StringToVectorDouble(amounts_string);
 }
 
+void SetFetchOldBalanceEnabled(bat_ledger::LedgerImpl* ledger, bool enabled) {
+  DCHECK(ledger);
+  ledger->SetBooleanState(ledger::kStateFetchOldBalance, enabled);
+}
+
+bool GetFetchOldBalanceEnabled(bat_ledger::LedgerImpl* ledger) {
+  DCHECK(ledger);
+  return ledger->GetBooleanState(ledger::kStateFetchOldBalance);
+}
+
 }  // namespace braveledger_state

vendor/bat-native-ledger/src/bat/ledger/internal/state/state_util.h

@@ -119,6 +119,10 @@ std::vector<double> GetTipChoices(bat_ledger::LedgerImpl* ledger);
 
 std::vector<double> GetMonthlyTipChoices(bat_ledger::LedgerImpl* ledger);
 
+void SetFetchOldBalanceEnabled(bat_ledger::LedgerImpl* ledger, bool enabled);
+
+bool GetFetchOldBalanceEnabled(bat_ledger::LedgerImpl* ledger);
+
 }  // namespace braveledger_state
 
 #endif  // BRAVELEDGER_STATE_STATE_UTIL_H_

vendor/bat-native-ledger/src/bat/ledger/internal/wallet/balance.cc

@@ -11,11 +11,13 @@
 #include <vector>
 
 #include "base/json/json_reader.h"
+#include "base/strings/stringprintf.h"
 #include "bat/ledger/global_constants.h"
 #include "bat/ledger/internal/ledger_impl.h"
 #include "bat/ledger/internal/uphold/uphold.h"
 #include "bat/ledger/internal/request/request_util.h"
 #include "bat/ledger/internal/static_values.h"
+#include "bat/ledger/internal/state/state_util.h"
 #include "net/http/http_status_code.h"
 
 using std::placeholders::_1;
@@ -33,9 +35,19 @@ Balance::~Balance() {
 }
 
 void Balance::Fetch(ledger::FetchBalanceCallback callback) {
+  // if we don't have user funds in anon card anymore
+  // we can skip balance server ping
+  if (!braveledger_state::GetFetchOldBalanceEnabled(ledger_)) {
+    auto balance = ledger::Balance::New();
+    GetUnBlindedTokens(std::move(balance), callback);
+    return;
+  }
+
   std::string payment_id = ledger_->GetPaymentId();
 
-  std::string path = "/wallet/" + payment_id + "/balance";
+  std::string path = base::StringPrintf(
+      "/wallet/%s/balance",
+      payment_id.c_str());
   const std::string url = braveledger_request_util::BuildUrl(
       path,
       PREFIX_V2,
@@ -87,6 +99,9 @@ void Balance::OnFetch(
 
   balance->wallets.insert(std::make_pair(ledger::kWalletAnonymous, total_anon));
 
+  if (balance->total == 0.0) {
+    braveledger_state::SetFetchOldBalanceEnabled(ledger_, false);
+  }
 
   GetUnBlindedTokens(std::move(balance), callback);
 }
@@ -99,6 +114,7 @@ void Balance::GetUnBlindedTokens(
     callback(ledger::Result::LEDGER_ERROR, std::move(balance));
     return;
   }
+
   auto tokens_callback = std::bind(&Balance::OnGetUnBlindedTokens,
       this,
       *balance,

vendor/bat-native-ledger/src/bat/ledger/internal/wallet/create.cc

@@ -299,6 +299,7 @@ void Create::RegisterPersonaCallback(
   ledger_->SetAutoContributeEnabled(true);
   braveledger_state::SetPaymentId(ledger_, payment_id);
   braveledger_state::SetAnonymousCardId(ledger_, card_id);
+  braveledger_state::SetFetchOldBalanceEnabled(ledger_, false);
   ledger_->SetCreationStamp(braveledger_time_util::GetCurrentTimeStamp());
   ledger_->ResetReconcileStamp();
   braveledger_state::SetInlineTippingPlatformEnabled(

vendor/bat-native-ledger/src/bat/ledger/internal/wallet/recover.cc

@@ -255,6 +255,7 @@ void Recover::RecoverWalletCallback(
   braveledger_state::SetRecoverySeed(ledger_, new_seed);
   braveledger_state::SetPaymentId(ledger_, recovery_id);
   braveledger_state::SetAnonymousCardId(ledger_, card_id);
+  braveledger_state::SetFetchOldBalanceEnabled(ledger_, true);
   ledger_->SetConfirmationsWalletInfo();
 
   callback(ledger::Result::LEDGER_OK, balance);