Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ad-block (cpp) and fix packaging for new ad-block lists #138

Merged
merged 3 commits into from
Jul 2, 2020

Conversation

pes10k
Copy link
Contributor

@pes10k pes10k commented Jun 17, 2020

Fix #143
Fix #131
Fix #130

  • removes ad-block and related CPP libs (easier to keep up with node, hurray)
  • removes other not currently used lists (extension list, Tracking protection list, etc)
  • fixes component packaging for new ad-block lists

Test Plan:

  1. Open Brave Browser with --use-dev-goupdater-url
  2. Navigate to brave://components and verify Ad-block Updater and Local Component Updater download works
  3. Navigate to cnn.com - and confirm that ads are blocked
  4. Navigate to https://chrome.google.com/webstore/detail/1password-extension-deskt/aomjjhallfgjeglblehebfpbcfeobpgk - Install and confirm the extension warning is not displayed
  5. Navigate to <user-dir>/cffkpbalmllkdoenhmdmpbkajipdjfam - Confirm the cpp dat files are not present
  6. Navigate to <user-dr>/afalakplffnnnlkncjhbmahjfjhmlkal/<version>/1 - Confirm that TrackingProtection.dat and StorageTrackingProtection.dat files are not present
  7. Navigate to brave://adblock, select all - and confirm that all components download without any issues

Copy link
Member

@bbondy bbondy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but before merging please test this on staging. @jumde can help with how to do that.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
scripts/packageComponent.js Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@jumde jumde force-pushed the remove-cpp-adblock branch from 615e4f0 to e32953c Compare June 25, 2020 22:40
@jumde jumde changed the title Remove ad-block (cpp) steps from the process, and other not-currently-used DATs [WIP] Remove ad-block (cpp) steps from the process, and other not-currently-used DATs Jun 26, 2020
@jumde jumde force-pushed the remove-cpp-adblock branch 2 times, most recently from bc60ad0 to ce04b9f Compare June 26, 2020 04:38
@jumde jumde changed the title [WIP] Remove ad-block (cpp) steps from the process, and other not-currently-used DATs Remove ad-block (cpp) and fix packaging for new ad-block lists Jun 26, 2020
@jumde jumde force-pushed the remove-cpp-adblock branch from 65c8a78 to 6af9177 Compare July 1, 2020 07:04
@pes10k pes10k merged commit 1ed2888 into master Jul 2, 2020
@pes10k pes10k deleted the remove-cpp-adblock branch July 2, 2020 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants