-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ad-block (cpp) and fix packaging for new ad-block lists #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbondy
approved these changes
Jun 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but before merging please test this on staging. @jumde can help with how to do that.
jumde
suggested changes
Jun 18, 2020
jumde
force-pushed
the
remove-cpp-adblock
branch
from
June 25, 2020 22:40
615e4f0
to
e32953c
Compare
jumde
changed the title
Remove ad-block (cpp) steps from the process, and other not-currently-used DATs
[WIP] Remove ad-block (cpp) steps from the process, and other not-currently-used DATs
Jun 26, 2020
jumde
force-pushed
the
remove-cpp-adblock
branch
2 times, most recently
from
June 26, 2020 04:38
bc60ad0
to
ce04b9f
Compare
jumde
changed the title
[WIP] Remove ad-block (cpp) steps from the process, and other not-currently-used DATs
Remove ad-block (cpp) and fix packaging for new ad-block lists
Jun 26, 2020
bbondy
approved these changes
Jun 26, 2020
jumde
force-pushed
the
remove-cpp-adblock
branch
from
June 26, 2020 16:15
359b014
to
e7a9453
Compare
jumde
force-pushed
the
remove-cpp-adblock
branch
2 times, most recently
from
June 29, 2020 20:09
4ce1738
to
c88839d
Compare
32 tasks
…ania adblock-lists
jumde
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #143
Fix #131
Fix #130
Test Plan:
--use-dev-goupdater-url
Ad-block Updater
andLocal Component Updater
download works<user-dir>/cffkpbalmllkdoenhmdmpbkajipdjfam
- Confirm thecpp dat
files are not present<user-dr>/afalakplffnnnlkncjhbmahjfjhmlkal/<version>/1
- Confirm thatTrackingProtection.dat
andStorageTrackingProtection.dat
files are not present