Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install pywin32 into depot_tools's python. #7333

Merged
merged 1 commit into from
Dec 12, 2019
Merged

Conversation

mkarolin
Copy link
Contributor

@mkarolin mkarolin commented Dec 11, 2019

depot_tools is currently missing pywin32 on Windows which is needed
by build/toolchain/win/tool_wrapper.py.

Fixes: #7328

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@mkarolin mkarolin added this to the 1.4.x - Nightly milestone Dec 11, 2019
@mkarolin mkarolin self-assigned this Dec 11, 2019
depot_tools is currently missing pywin32 on Windows which is needed
by build/toolchain/win/tool_wrapper.py.

Fixes #7328
@mkarolin
Copy link
Contributor Author

CI passed: MacOS failed in the first job for an unrelated reason. MacOS succeeded in the second job.

@mkarolin mkarolin changed the title WIP: Install pywin32 into depot_tools's python. Install pywin32 into depot_tools's python. Dec 12, 2019
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ LGTM! (tested and it works great)

@bsclifton
Copy link
Member

bsclifton commented Dec 12, 2019

NOTE: this only happens during init. Output looks like this:

Manually installing pywin32 python module
C:\brave-browser: python -m pip install pywin32
DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 won't be maintained after that date. A future version of pip will drop support for Python 2.7. More details about Python 2 support in pip, can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support
Collecting pywin32
  Downloading https://files.pythonhosted.org/packages/a2/e6/6b395ea8bc9500158adea646e28077adb7f3d9587c681fd5d03693a4b5dc/pywin32-227-cp27-cp27m-win_amd64.whl (7.4MB)
Installing collected packages: pywin32
Successfully installed pywin32-227

@bsclifton bsclifton merged commit 2eaaf5d into master Dec 12, 2019
@bsclifton bsclifton deleted the maxk-fix-pywin32 branch December 12, 2019 05:47
mkarolin pushed a commit that referenced this pull request Dec 12, 2019
Install pywin32 into depot_tools's python.
mkarolin pushed a commit that referenced this pull request Dec 12, 2019
Install pywin32 into depot_tools's python.
mkarolin pushed a commit that referenced this pull request Dec 12, 2019
Install pywin32 into depot_tools's python.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImportError: No module named win32file
2 participants