-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install pywin32 into depot_tools's python. #7333
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
depot_tools is currently missing pywin32 on Windows which is needed by build/toolchain/win/tool_wrapper.py. Fixes #7328
mkarolin
force-pushed
the
maxk-fix-pywin32
branch
from
December 12, 2019 02:13
a8e8f2e
to
01ccdbe
Compare
CI passed: MacOS failed in the first job for an unrelated reason. MacOS succeeded in the second job. |
mkarolin
changed the title
WIP: Install pywin32 into depot_tools's python.
Install pywin32 into depot_tools's python.
Dec 12, 2019
bsclifton
approved these changes
Dec 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ LGTM! (tested and it works great)
NOTE: this only happens during
|
28 tasks
mkarolin
pushed a commit
that referenced
this pull request
Dec 12, 2019
Install pywin32 into depot_tools's python.
mkarolin
pushed a commit
that referenced
this pull request
Dec 12, 2019
Install pywin32 into depot_tools's python.
mkarolin
pushed a commit
that referenced
this pull request
Dec 12, 2019
Install pywin32 into depot_tools's python.
This was referenced Dec 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depot_tools is currently missing pywin32 on Windows which is needed
by build/toolchain/win/tool_wrapper.py.
Fixes: #7328
Submitter Checklist:
git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.