-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace chrome branding strings in management_strings.grdp #6475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 tasks
mkarolin
previously approved these changes
Oct 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks like CI build failed for Android, but unrelated to these changes. |
@mkarolin Oh, thanks for checking. fix for that build failure is pushed to corresponding b-c PR(brave/brave-core#3692). |
darkdh
reviewed
Oct 16, 2019
simonhong
force-pushed
the
group_policy_for_tor
branch
from
October 17, 2019 14:17
8e6fd91
to
fed8fea
Compare
simonhong
force-pushed
the
group_policy_for_tor
branch
from
October 28, 2019 02:47
fed8fea
to
abc8086
Compare
darkdh
previously approved these changes
Oct 28, 2019
simonhong
force-pushed
the
group_policy_for_tor
branch
3 times, most recently
from
November 4, 2019 00:45
6ec3df2
to
8c2acff
Compare
This replaces chrome string in brave://management webui page.
simonhong
force-pushed
the
group_policy_for_tor
branch
from
November 5, 2019 01:44
8c2acff
to
5c3d807
Compare
darkdh
approved these changes
Nov 5, 2019
simonhong
added a commit
that referenced
this pull request
Nov 7, 2019
Replace chrome branding strings in management_strings.grdp
4 tasks
simonhong
added a commit
that referenced
this pull request
Nov 7, 2019
Replace chrome branding strings in management_strings.grdp
4 tasks
brave-builds
pushed a commit
that referenced
this pull request
Nov 11, 2019
Replace chrome branding strings in management_strings.grdp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces chrome string in brave://management webui page.
Issue: #454
Submitter Checklist:
git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.