Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace chrome branding strings in management_strings.grdp #6475

Merged
merged 1 commit into from
Nov 5, 2019

Conversation

simonhong
Copy link
Member

This replaces chrome string in brave://management webui page.

Issue: #454

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@simonhong simonhong added this to the 0.72.x - Nightly milestone Oct 15, 2019
@simonhong simonhong requested a review from mkarolin October 15, 2019 10:24
@simonhong simonhong self-assigned this Oct 15, 2019
@simonhong simonhong requested a review from bsclifton October 15, 2019 10:24
mkarolin
mkarolin previously approved these changes Oct 15, 2019
Copy link
Contributor

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkarolin
Copy link
Contributor

Looks like CI build failed for Android, but unrelated to these changes.

@simonhong
Copy link
Member Author

simonhong commented Oct 15, 2019

@mkarolin Oh, thanks for checking. fix for that build failure is pushed to corresponding b-c PR(brave/brave-core#3692).

darkdh
darkdh previously approved these changes Oct 28, 2019
@simonhong simonhong force-pushed the group_policy_for_tor branch 3 times, most recently from 6ec3df2 to 8c2acff Compare November 4, 2019 00:45
This replaces chrome string in brave://management webui page.
@simonhong simonhong force-pushed the group_policy_for_tor branch from 8c2acff to 5c3d807 Compare November 5, 2019 01:44
@simonhong simonhong requested a review from darkdh November 5, 2019 23:06
@simonhong simonhong merged commit 4882c43 into master Nov 5, 2019
@simonhong simonhong deleted the group_policy_for_tor branch November 5, 2019 23:09
simonhong added a commit that referenced this pull request Nov 7, 2019
Replace chrome branding strings in management_strings.grdp
simonhong added a commit that referenced this pull request Nov 7, 2019
Replace chrome branding strings in management_strings.grdp
brave-builds pushed a commit that referenced this pull request Nov 11, 2019
Replace chrome branding strings in management_strings.grdp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants