-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update from Chromium 77.0.3865.90 to Chromium 78.0.3904.44 #6311
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 3, 2019
mkarolin
changed the title
Update from Chromium 77.0.3865.75 to Chromium 78.0.3904.44
Update from Chromium 77.0.3865.90 to Chromium 78.0.3904.44
Oct 4, 2019
mkarolin
force-pushed
the
78.0.3904.44
branch
4 times, most recently
from
October 7, 2019 21:51
f3a1a9e
to
603081d
Compare
mkarolin
changed the title
Update from Chromium 77.0.3865.90 to Chromium 78.0.3904.44
WIP: Update from Chromium 77.0.3865.90 to Chromium 78.0.3904.44
Oct 8, 2019
We could update CI to download/unzip/install the CDM binaries (header, manifest, etc)... but that would only be appropriate if we wanted to bundle CDM. We don't intend to bundle Widevine, instead we are distributing using component updater. Stub needed after Chromium change: https://chromium.googlesource.com/chromium/src/+/90c6eb5176bf1347001dde9edd27aa8b70b74186 commit 90c6eb5176bf1347001dde9edd27aa8b70b74186 Author: John Rummell <jrummell@chromium.org> Date: Thu Aug 29 21:07:24 2019 +0000 Move CDMs into platform specific paths on Linux Rather than including the CDMs in the base install directory, move them into subdirectories (e.g. Widevine would be located in <installdir>/WidevineCdm/_platform_specific/linux_x64/libwidevinecdm.so). This allows the LICENSE and manifest.json file to be bundled with Chrome on Linux. Future CL's will use the manifest.json file to determine the capabilities of the CDM (rather than having them hardcoded as they are today). In addition to the unittests below, ran EME browser_tests (both ECK and Widevine) to check that the library can be loaded from it's new directory, and built "installer" (although I don't know if whatever package it creates is installable). Bug: 971433
Chromium change: https://chromium.googlesource.com/chromium/src/+/9797cc66ad6e9987f00272120835b840d7c132b5 commit 9797cc66ad6e9987f00272120835b840d7c132b5 Author: Hector Carmona <hcarmona@chromium.org> Date: Fri Aug 9 20:35:35 2019 +0000 [Reland] Navi: Remove usage of 'Onboarding' most places in welcome code. Bug: 986979
Chromium change: https://chromium.googlesource.com/chromium/src/+/8959d58944bda5168d522fc7bd4cb232b615a05a commit 8959d58944bda5168d522fc7bd4cb232b615a05a Author: Tommy Steimel <steimel@chromium.org> Date: Wed Aug 7 17:53:52 2019 +0000 GMC: Add tooltip text to toolbar icon This CL adds tooltip text to the global media controls toolbar icon. Bug: 991271
Chromium change: https://chromium.googlesource.com/chromium/src/+/2c1f2716ee49f77272c3a986b9caee86ae3430c7 commit 2c1f2716ee49f77272c3a986b9caee86ae3430c7 Author: yilkal <yilkal@chromium.org> Date: Wed Aug 14 16:21:25 2019 +0000 Move supervised user strings to chrome/app. Moved supervised_user_error_page_strings.grdp, supervised_user_error_page_strings_grdp/ to chrome/app/. This is to resolve translation extraction failure for chrome client project. Updated references in chrome/app/generated_resources.grd Bug: 993353
bsclifton
changed the title
WIP: Update from Chromium 77.0.3865.90 to Chromium 78.0.3904.44
Update from Chromium 77.0.3865.90 to Chromium 78.0.3904.44
Oct 9, 2019
bsclifton
approved these changes
Oct 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes here LGTM 👍
Closing in favor of #6396 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6067
Related PR brave/brave-core#3600
Submitter Checklist:
git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.