Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 76.0.3809.100 to Chromium 76.0.3809.132 (uplift to 0.68.x) #5810

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Aug 26, 2019

Fixes #5801

Uplift of #5806
Related brave/brave-core#3261

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

Upgrade from Chromium 76.0.3809.100 to Chromium 76.0.3809.132
@bsclifton bsclifton added this to the 0.68.x - Release Hotfix 1 milestone Aug 26, 2019
@bsclifton bsclifton requested a review from a team August 26, 2019 23:44
@bsclifton bsclifton changed the title Merge pull request #5806 from brave/76.0.3809.132 Upgrade from Chromium 76.0.3809.100 to Chromium 76.0.3809.132 (uplift to 0.68.x) Aug 26, 2019
@kjozwiak
Copy link
Member

@bsclifton @mkarolin can you take a please take a look at https://staging.ci.brave.com/job/brave-browser-build-pr/job/PR-5810/2/execution/node/217/log/? There seems to be several errors, example:

20:51:07  FAILED: gen/chrome/android/chrome_java.javac.jar.errorprone.jar gen/chrome/android/chrome_java.javac.jar.errorprone.jar.info 
20:51:08  FAILED: gen/chrome/android/chrome_java.javac.jar gen/chrome/android/chrome_java.javac.jar.info 

Looks like it stopped at 20:51:35 [34100/40121] ACTION //chrome/android:chrome_java__lint(//build/toolchain/android:android_clang_arm)

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.68.x approved. Please make sure that all the correct labels are being used and the appropriate issue is moved into the correct milestone.

@bsclifton bsclifton merged commit 7400290 into 0.68.x Aug 27, 2019
@bsclifton bsclifton deleted the c76bump-0.68.x branch August 27, 2019 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants