Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release notes for 0.56.x Hotfix 1 #2197

Merged
merged 1 commit into from
Nov 20, 2018
Merged

Release notes for 0.56.x Hotfix 1 #2197

merged 1 commit into from
Nov 20, 2018

Conversation

kjozwiak
Copy link
Member

Fix #2194

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Requested a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

@kjozwiak kjozwiak added this to the 0.56.x - Release Hotfix 1 milestone Nov 20, 2018
@kjozwiak kjozwiak self-assigned this Nov 20, 2018
@kjozwiak kjozwiak changed the title Release notes for 0.56.x1 Hotfix 1 Release notes for 0.56.x Hotfix 1 Nov 20, 2018
rebron
rebron approved these changes Nov 20, 2018
View reviewed changes
Copy link
Collaborator

@rebron rebron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kjozwiak kjozwiak merged commit f77c23b into master Nov 20, 2018
@kjozwiak kjozwiak deleted the release-notes-0.56.x-hotfix1 branch November 20, 2018 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy bbondy approved these changes

@rebron rebron rebron approved these changes

Assignees

@kjozwiak kjozwiak

Labels
QA/No release-notes/exclude
Projects
None yet
Milestone
0.56.x - Release Hotfix 1 (Release Ch...
Development

Successfully merging this pull request may close these issues.
3 participants
@kjozwiak @bbondy @rebron