Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs/installing-brave.rst: add brave-keyring package entry #2057

Merged
merged 1 commit into from
Nov 9, 2018
Merged

docs/installing-brave.rst: add brave-keyring package entry #2057

merged 1 commit into from
Nov 9, 2018

Conversation

bkero
Copy link
Contributor

@bkero bkero commented Nov 9, 2018

This commit adds the brave-keyring package entry to the instructions for
installing the release version of brave-browser

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Requested a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

@bkero
docs/installing-brave.rst: add brave-keyring package entry
0b22b59 
This commit adds the brave-keyring package entry to the instructions for
installing the release version of brave-browser

References: #1826
mbacchi
mbacchi approved these changes Nov 9, 2018
View reviewed changes
Copy link
Contributor

@mbacchi mbacchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@diracdeltas
Copy link
Member

diracdeltas commented Nov 9, 2018 •
edited
Loading

note for the person merging this: this fixes #2037 (assuming it's done after the keyring package is uploaded)

@bkero bkero merged commit d5e544e into master Nov 9, 2018
@bkero bkero deleted the add-bravekeyring-docs branch November 9, 2018 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diracdeltas diracdeltas diracdeltas approved these changes

@mbacchi mbacchi mbacchi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkero @diracdeltas @mbacchi