Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Centos instructions #1905

Merged
merged 1 commit into from
Oct 31, 2018
Merged

Add Centos instructions #1905

merged 1 commit into from
Oct 31, 2018

Conversation

posix4e
Copy link
Contributor

@posix4e posix4e commented Oct 30, 2018 •
edited
Loading

Tweak fedora instructions for dev to point to correct rpm rpo

Closes #1904

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Linux

Test Plan:

Tested in a vagrant

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

@posix4e posix4e changed the title Add Centos instructions Add Centos instructions WIP DO NOT MERGE Oct 30, 2018
@posix4e posix4e force-pushed the patch-1 branch 2 times, most recently from af542a8 to eb5cfbe Compare October 30, 2018 18:28
@posix4e
Add Centos instructions
0b73e17 
Tweak fedora instructions for dev to point to correct rpm rpo
@posix4e posix4e changed the title Add Centos instructions WIP DO NOT MERGE Add Centos instructions Oct 30, 2018
mbacchi
mbacchi approved these changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@mbacchi mbacchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bbondy
Copy link
Member

bbondy commented Oct 31, 2018

Thanks!

@bbondy bbondy merged commit 9cd7080 into brave:master Oct 31, 2018
@bbondy bbondy added this to the 0.58.x - Nightly milestone Oct 31, 2018
@bsclifton bsclifton mentioned this pull request Jan 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbacchi mbacchi mbacchi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.58.x - Release (Release Channel)
Development

Successfully merging this pull request may close these issues.
4 participants
@posix4e @bbondy @mbacchi @bdekany