Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add settings to disable top sites and Brave suggested sites in address bar autocomplete #9572

Closed
bbondy opened this issue May 1, 2020 · 1 comment · Fixed by brave/brave-core#5438 or brave/brave-core#5488
Closed

Add settings to disable top sites and Brave suggested sites in address bar autocomplete #9572

bbondy opened this issue May 1, 2020 · 1 comment · Fixed by brave/brave-core#5438 or brave/brave-core#5488
Assignees
@bbondy
Labels
feature/autocomplete feature/settings OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.9.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented May 1, 2020

Description

Currently you can only completely disable autocomplete.
It would be good for a user to be able to disable either or both of the alexa top site suggestions and the brave suggested sites.

Screen Shot 2020-05-01 at 11 12 42 AM

Test plan

  • Type Bitcoin and see the Binance suggestion, disable the preference and doing the same should not suggest it anymore.
  • Type slash and see the top site suggestion for slashdot. Do it again with the setting off and it should not show that suggestion.
@bbondy bbondy added the QA/Yes label May 1, 2020
@bbondy bbondy self-assigned this May 1, 2020
@bbondy bbondy added this to the 1.10.x - Nightly milestone May 1, 2020
@bbondy bbondy mentioned this issue May 1, 2020
Merged
32 tasks
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 1, 2020
@rebron rebron mentioned this issue May 5, 2020
Closed
@rebron rebron mentioned this issue May 7, 2020
Closed
@bbondy bbondy mentioned this issue May 7, 2020
Merged
4 tasks
@rebron rebron modified the milestones: 1.10.x - Beta, 1.9.x - Release May 17, 2020
@rebron rebron mentioned this issue May 17, 2020
Closed
@LaurenWags
Copy link
Member

LaurenWags commented May 19, 2020 •
edited by btlechowski
Loading

Verified passed with

Brave 1.9.70 Chromium: 81.0.4044.138 (Official Build) (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS macOS Version 10.14.6 (Build 18G3020)

Show Brave suggested sites in autocomplete suggestions on:
Screen Shot 2020-05-19 at 8 03 03 AM

Show Brave suggested sites in autocomplete suggestions off:
Screen Shot 2020-05-19 at 8 03 41 AM

Show top sites in autocomplete suggestions on:
Screen Shot 2020-05-19 at 8 04 00 AM

Show top sites in autocomplete suggestions off:
Screen Shot 2020-05-19 at 8 04 19 AM

Verification passed on

Brave 1.9.70 Chromium: 81.0.4044.138 (Official Build) (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Show Brave suggested sites in autocomplete suggestions on:
image
image
image

Show Brave suggested sites in autocomplete suggestions off:
image
image
image

Show top sites in autocomplete suggestions on:
image
image
image

Show top sites in autocomplete suggestions off:
image
image
image

Verification passed on

Brave 1.9.70 Chromium: 81.0.4044.138 (Official Build) (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS Ubuntu 18.04 LTS

Show Brave suggested sites in autocomplete suggestions on:
image

Show Brave suggested sites in autocomplete suggestions off:
image

Show top sites in autocomplete suggestions on:
image

Show top sites in autocomplete suggestions off:
image

@rebron rebron changed the title Add a setting to disable top site and brave suggested site suggestions Add a setting to disable top sites and Brave suggested sites in address bar autocomplete May 20, 2020
@rebron rebron changed the title Add a setting to disable top sites and Brave suggested sites in address bar autocomplete Add settings to disable top sites and Brave suggested sites in address bar autocomplete May 20, 2020
@LaurenWags LaurenWags mentioned this issue May 20, 2020
Closed
@sav-valerio sav-valerio mentioned this issue May 24, 2020
Open
@ryanml ryanml mentioned this issue Jun 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbondy bbondy

Labels
feature/autocomplete feature/settings OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.9.x - Release
6 participants
@bbondy @bsclifton @rebron @LaurenWags @btlechowski @GeetaSarvadnya