Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stablecoins are not reflected in total account value [Binance Widget] #9559

Closed
ryanml opened this issue Apr 30, 2020 · 2 comments · Fixed by brave/brave-core#5447
Closed

Comments

@ryanml
Copy link
Contributor

ryanml commented Apr 30, 2020

Description

Stablecoins such as BUSD and USDT are not accounted for in the total account USD/BTC value.

Steps to Reproduce

  1. Have a mixture of assets in your binance.com account plus BUSD/USDT
  2. Connect to the Binance Widget
  3. Unobscure the account values

Actual result:

BUSD/USDT are not accounted for the in the total account value (First summary entry)

Expected result:

The values of those assets should be factored in to the total, in both BTC and USD

Reproduces how often:

100%

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label May 1, 2020
@ryanml ryanml self-assigned this May 2, 2020
@ryanml ryanml added this to the 1.10.x - Nightly milestone May 2, 2020
ryanml added a commit to brave/brave-core that referenced this issue May 2, 2020
Depcrecates v1 API methods for getting symbol prices

Removes volume endpoints (Dead Code
ryanml added a commit to brave/brave-core that referenced this issue May 4, 2020
Depcrecates v1 API methods for getting symbol prices

Removes volume endpoints (Dead Code
@srirambv
Copy link
Contributor

srirambv commented May 7, 2020

Verification passed on

Brave 1.8.95 Chromium: 81.0.4044.138 (Official Build) (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{# 999}
OS Linux
  • Verified on 1.8.90 stablecoins are not part of the total balance
  • Verified upgrading from 1.8.90 to 1.8.95, automatically updates balance to include stablecoin
  • Verified on a clean install, widget balance shows cumulative balance of all available assets
  • Verified on upgrade clicking on refresh button immediately updates the balance to include stablecoin

Verification passed on

Brave 1.8.95 Chromium: 81.0.4044.138 (Official Build) (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{# 999}
OS macOS Version 10.15.4 (Build 19E287)
  • Verified on 1.8.90 stablecoins are not part of the total balance
  • Verified upgrading from 1.8.90 to 1.8.95, automatically updates balance to include stablecoin
  • Verified on a clean install, widget balance shows cumulative balance of all available assets
  • Verified on upgrade clicking on refresh button immediately updates the balance to include stablecoin

Verification passed on

Brave 1.8.95 Chromium: 81.0.4044.138 (Official Build) (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{# 999}
OS Windows 10 OS Version 1809 (Build 17763.1158)
  • Verified on 1.8.90 stablecoins are not part of the total balance
  • Verified upgrading from 1.8.90 to 1.8.95, automatically updates balance to include stablecoin
  • Verified on a clean install, widget balance shows cumulative balance of all available assets
  • Verified on upgrade clicking on refresh button immediately updates the balance to include stablecoin

@LaurenWags
Copy link
Member

Adding release-notes/include per discussion with @srirambv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants