Ability to modify New Tab Page Sponsored Images from Settings

[jonathansampson]

Description

Users who are attempting to modify/disable New Tab Page Sponsored Images are at times looking within about:settings (Brave's global Settings) and failing to locate controls for NTP SIs. Presently, this feature is controlled from the New Tab Page itself, by clicking the Dashboard button at the bottom-right.

Brave version (brave://version info)

1.5.113

Additional Information

Sponsored Images are enabled and disabled from within general Settings on iOS and Android.

Designs

Accessed via brave://settings/newtab

Add a "New Tab Page" section in Settings.

The controls shown in Settings are duplicates linked to the controls on the new tab page:

Assets

icon asset.zip

[mandar-brave]

@rebron please prioritize. Please make settings a dupe of what is available on NTP.
cc @bradleyrichter

[karenkliu]

Designs added!

[GeetaSarvadnya]

Verification passed on

Brave | 1.9.55 Chromium: 81.0.4044.129 (Official Build) dev (64-bit)
-- | --
Revision | 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

• Verified the test plan from NTP: Add settings section for Dashboard options brave-core#5151 and also verified Make SI option works in settings page brave-core#5310 (comment)
• Verified that Toggling an option in New Tab Settings reflected on the NTP dashboard settings and vice versa.
  
• Verified that, If Background images toggle is OFF, Sponsored images is also in disabled state.
  
• Verified that new tab brave://settings/newTab section order is reflected as mentioned in the Ability to modify New Tab Page Sponsored Images from Settings #8760 (comment).
  

---

Verification passed on

Brave	1.9.61 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
Revision	8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{# 999}
OS	Linux

• Verified disabling Background images disables Sponsored images as well in both settings and dashboard
  
• Verified that Toggling an option in New Tab Settings reflected on the NTP dashboard settings and vice versa.
• Verified that settings has a new section for NTP settings as per design
  

---

Verified passed with

Brave	1.9.62 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
Revision	8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS	macOS Version 10.14.6 (Build 18G3020)

• Verified test plan from NTP: Add settings section for Dashboard options brave-core#5151
• Confirmed order of settings from Ability to modify New Tab Page Sponsored Images from Settings #8760 (comment)
• Verified test pan from Make SI option works in settings page brave-core#5310 (comment)
• Using clean profile with 1.9.x, confirmed toggling items on brave://settings/newTab updated NTP. Confirmed toggling settings on NTP updated brave://settings/newTab toggles.
• Using profile from 1.8.x, toggled various items off and upgraded to 1.9.x. Confirmed items were still off as expected on upgrade and confirmed that the NTP settings matched brave://settings/newTab.