Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify check is shown on top of notification counter #7121

Closed
NejcZdovc opened this issue Nov 27, 2019 · 1 comment · Fixed by brave/brave-core#4160
Closed

Verify check is shown on top of notification counter #7121

NejcZdovc opened this issue Nov 27, 2019 · 1 comment · Fixed by brave/brave-core#4160
Assignees

Comments

@NejcZdovc
Copy link
Contributor

Description

Steps to Reproduce

  1. start browser on staging
  2. enable rewards
  3. don't claim promotion, but make sure that you see it
  4. visit verified publisher

Actual result:

Verified checkmark is shown.

Expected result:

Notification counter should be still shown until you clear it. This way user can't miss important notifications while browsing verified site.

Reproduces how often:

100%

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@NejcZdovc NejcZdovc added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 27, 2019
@NejcZdovc NejcZdovc self-assigned this Dec 6, 2019
@NejcZdovc NejcZdovc added this to the 1.4.x - Nightly milestone Dec 6, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Dec 6, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Jan 22, 2020

Verified passed with

Brave 1.4.66 Chromium: 79.0.3945.130 (Official Build) dev (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS macOS Version 10.14.6 (Build 18G103)

Screen Shot 2020-01-22 at 4 35 57 PM

Screen Shot 2020-01-22 at 4 36 09 PM

Screen Shot 2020-01-22 at 4 36 53 PM

Verification passed on

Brave 1.4.84 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Ubuntu 18.04 LTS

Grant available
image
image

Verified publisher
image
image

After claiming the grant
image

Verification passed on

Brave 1.4.84 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants