Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests for virtual grants #6949

Closed
NejcZdovc opened this issue Nov 15, 2019 · 0 comments
Closed

Unit tests for virtual grants #6949

NejcZdovc opened this issue Nov 15, 2019 · 0 comments
Labels
closed/not-actionable feature/rewards

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Nov 15, 2019 •
edited by masparrow
Loading

With virtual grants we added a lot of code, so we need to add unit tests for this new code as well. We should create a lit of all functions that need testing.

List of functions:

Draft list;

  • contribution_unblinded::Start
  • bind_util: FromPromotionToString / FromStringToPromotion
  • internal/common/security_helper: see confirmations Security test for examples
  • ledger/internal/promotion - all public facing

If any areas need improvement, raise issues for tidy ups
@NejcZdovc NejcZdovc added feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. labels Nov 15, 2019
@NejcZdovc NejcZdovc mentioned this issue Nov 15, 2019
Closed
13 tasks
masparrow added a commit to brave/brave-core that referenced this issue Jan 9, 2020
@masparrow
Unit tests for virtual grants
280a617 
Resolves brave/brave-browser#6949

- Bind Utils
- Promotion
- Promotion Utils
- Security Helper (Ledger
@masparrow masparrow mentioned this issue Jan 9, 2020
Closed
32 tasks
masparrow added a commit to brave/brave-core that referenced this issue Jan 9, 2020
@masparrow
Unit tests for virtual grants
d70a661 
Resolves brave/brave-browser#6949

- Bind Utils
- Promotion
- Promotion Utils
- Security Helper (Ledger

Update

a
masparrow added a commit to brave/brave-core that referenced this issue Jan 31, 2020
@masparrow
Unit tests for virtual grants
c2783ae 
Resolves brave/brave-browser#6949

- Bind Utils
- Promotion
- Promotion Utils
- Security Helper (Ledger

Update

a
NejcZdovc pushed a commit to brave/brave-core that referenced this issue Feb 12, 2020
@masparrow @NejcZdovc
Unit tests for virtual grants
238214f 
Resolves brave/brave-browser#6949

- Bind Utils
- Promotion
- Promotion Utils
- Security Helper (Ledger

Update

a
masparrow added a commit to brave/brave-core that referenced this issue Feb 14, 2020
@masparrow
Unit tests for virtual grants
5554c29 
Resolves brave/brave-browser#6949

- Bind Utils
- Promotion
- Promotion Utils
- Security Helper (Ledger
masparrow added a commit to brave/brave-core that referenced this issue Feb 21, 2020
@masparrow
Unit tests for virtual grants
97ef9f1 
Resolves brave/brave-browser#6949

- Bind Utils
- Promotion
- Promotion Utils
- Security Helper (Ledger
masparrow added a commit to brave/brave-core that referenced this issue Mar 1, 2020
@masparrow
Unit tests for virtual grants
cf7671b 
Resolves brave/brave-browser#6949

- Bind Utils
- Promotion
- Promotion Utils
- Security Helper (Ledger
masparrow added a commit to brave/brave-core that referenced this issue Mar 2, 2020
@masparrow
Unit tests for virtual grants
140acc7 
Resolves brave/brave-browser#6949

- Bind Utils
- Promotion
- Promotion Utils
- Security Helper (Ledger
masparrow added a commit to brave/brave-core that referenced this issue Mar 17, 2020
@masparrow
Unit tests for virtual grants
1601086 
Resolves brave/brave-browser#6949

- Bind Utils
- Promotion
- Promotion Utils
- Security Helper (Ledger
masparrow added a commit to brave/brave-core that referenced this issue Mar 19, 2020
@masparrow
Unit tests for virtual grants
f377ce5 
Resolves brave/brave-browser#6949

- Bind Utils
- Promotion
- Promotion Utils
- Security Helper (Ledger)
@NejcZdovc NejcZdovc assigned NejcZdovc and unassigned masparrow Apr 9, 2020
@NejcZdovc NejcZdovc removed their assignment May 6, 2020
@NejcZdovc NejcZdovc removed the priority/P2 A bad problem. We might uplift this to the next planned release. label May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/not-actionable feature/rewards
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unit tests for virtual grants brave/brave-core
2 participants
@NejcZdovc @masparrow