-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promotion expiration #6947
Labels
feature/rewards
priority/P2
A bad problem. We might uplift this to the next planned release.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/exclude
Milestone
Comments
NejcZdovc
added
feature/rewards
priority/P2
A bad problem. We might uplift this to the next planned release.
labels
Nov 15, 2019
masparrow
added a commit
to brave/brave-core
that referenced
this issue
Nov 20, 2019
32 tasks
32 tasks
masparrow
added a commit
to brave/brave-core
that referenced
this issue
Nov 27, 2019
NejcZdovc
pushed a commit
to brave/brave-core
that referenced
this issue
Dec 3, 2019
gdregalo
pushed a commit
to brave/brave-core
that referenced
this issue
Jan 10, 2020
Verification passed on
Verified test plan from brave/brave-core#4035 Verification PASSED on
Before changing
|
Brave | 1.3.91 Chromium: 79.0.3945.117 (Official Build) beta (64-bit) |
---|---|
Revision | 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019} |
OS | Windows 10 OS Version 1803 (Build 17134.1006) |
- Verified the test plan from Promotion expiration brave-core#4035
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/rewards
priority/P2
A bad problem. We might uplift this to the next planned release.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/exclude
UGP promotions has expiration date so we need to handle it. Every time that we call fetch we need to go through list of promotions that we get from the db and check if any of it expired. If so we need to mark promotion is
OVER
and delete all unblinded tokes related to this promotion if any exists.The text was updated successfully, but these errors were encountered: